fix: support json files

app/lib/day_rotator.js

@@ -21,8 +21,13 @@ class DayRotator extends Rotator {
     const files = new Map();
     const loggers = this.app.loggers;
     for (const key in loggers) {
-      this._setFile(loggers[key].options.file, files);
+      const logger = loggers[key];
+      this._setFile(logger.options.file, files);
+      if (logger.options.jsonFile) {
+        this._setFile(logger.options.jsonFile, files);
+      }
     }
+
     // Should rotate agent log, because schedule is running under app worker,
     // agent log is the only differece between app worker and agent worker.
     // - app worker -> egg-web.log

test/fixtures/logrotator-json-format/config/config.default.js

@@ -0,0 +1,35 @@
+'use strict';
+
+const path = require('path');
+
+module.exports = () => {
+  const exports = {
+    logger: {
+      outputJSON: true,
+    },
+    logrotator: {
+      filesRotateByHour: [
+        path.join(__dirname, '../logs', 'logrotator', 'hour.log'),
+        path.join(__dirname, '../logs', 'logrotator', 'hour.json.log'),
+      ],
+      filesRotateBySize: [
+        path.join(__dirname, '../logs', 'logrotator', 'size.log'),
+        path.join(__dirname, '../logs', 'logrotator', 'size.json.log'),
+      ],
+      maxFileSize: 1,
+      maxFiles: 2,
+    },
+    customLogger: {
+      dayLogger: {
+        file: path.join(__dirname, '../logs', 'logrotator', 'day.log'),
+      },
+      sizeLogger: {
+        file: path.join(__dirname, '../logs', 'logrotator', 'size.log'),
+      },
+      hourLogger: {
+        file: path.join(__dirname, '../logs', 'logrotator', 'hour.log'),
+      },
+    },
+  };
+  return exports;
+};

test/fixtures/logrotator-json-format/package.json

@@ -0,0 +1,6 @@
+{
+  "name": "logrotator",
+  "dependencies": {
+  },
+  "private":true
+}

test/logrotator.test.js

@@ -51,7 +51,7 @@ describe('test/logrotator.test.js', () => {
       yield app.runSchedule(schedule);
 
       const files = glob.sync(path.join(app.config.logger.dir, '*.log.*'));
-      assert(files.length === 4);
+      assert(files.length > 4);
       assert(files.filter(name => name.indexOf('foo.log.') > 0));
       files.forEach(file => assert(/log.\d{4}-\d{2}-\d{2}$/.test(file)));
 
@@ -376,6 +376,52 @@ describe('test/logrotator.test.js', () => {
 
   });
 
+  describe('json logger', () => {
+    let app;
+    before(() => {
+      app = mm.app({
+        baseDir: 'logrotator-json-format',
+        cache: false,
+      });
+      return app.ready();
+    });
+    after(() => app.close());
+
+    it('should be rotated by day', function* () {
+      const logDir = app.config.logger.dir;
+      const now = moment().startOf('date');
+      const date = now.clone().subtract(1, 'days').format('YYYY-MM-DD');
+      const schedule = path.join(__dirname, '../app/schedule/rotate_by_file');
+      yield app.runSchedule(schedule);
+
+      assert(fs.existsSync(path.join(logDir, `day.log.${date}`)));
+      assert(fs.existsSync(path.join(logDir, `day.json.log.${date}`)));
+    });
+
+    it('should be rotated by hour', function* () {
+      const logDir = app.config.logger.dir;
+      const date = moment().subtract(1, 'hours').format('YYYY-MM-DD-HH');
+      const schedule = path.join(__dirname, '../app/schedule/rotate_by_hour');
+      yield app.runSchedule(schedule);
+
+      assert(fs.existsSync(path.join(logDir, `hour.log.${date}`)));
+      assert(fs.existsSync(path.join(logDir, `hour.json.log.${date}`)));
+    });
+
+    it('should be rotated by size', function* () {
+      app.getLogger('sizeLogger').info('size');
+      // wait flush
+      yield sleep(1000);
+
+      const logDir = app.config.logger.dir;
+      const schedule = path.join(__dirname, '../app/schedule/rotate_by_size');
+      yield app.runSchedule(schedule);
+
+      assert(fs.existsSync(path.join(logDir, 'size.log.1')));
+      assert(fs.existsSync(path.join(logDir, 'size.json.log.1')));
+    });
+  });
+
 });
 
 function sleep(ms) {