Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update globby #217

Closed
wants to merge 2 commits into from
Closed

Conversation

waitingsong
Copy link
Contributor

@waitingsong waitingsong commented Oct 9, 2019

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

update globby to ^10.0.0

@codecov
Copy link

codecov bot commented Oct 9, 2019

Codecov Report

Merging #217 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #217   +/-   ##
======================================
  Coverage    99.8%   99.8%           
======================================
  Files          19      19           
  Lines        1019    1019           
======================================
  Hits         1017    1017           
  Misses          2       2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40250e0...5a87325. Read the comment docs.

@atian25
Copy link
Member

atian25 commented Oct 9, 2019

globby 8 -> 10 的 break 点看了下:

看了下 egg-core 里面的代码,应该没问题。

@popomore 这个专门锁到 8 的原因是?

'globby@8',

@atian25 atian25 requested a review from popomore October 9, 2019 03:19
package.json Show resolved Hide resolved
@atian25
Copy link
Member

atian25 commented Oct 9, 2019

之前锁到 8 的原因:#215

@waitingsong
Copy link
Contributor Author

锁 globby@8 的原因是 "Don't throw when specifying a non-existing cwd directory" 导致原本期望抛出异常但 8之后版本都不抛异常,所以就只能锁定 8 么?

@atian25
Copy link
Member

atian25 commented Oct 9, 2019

锁是在那个 PR 之前吧, merge 后,就可以去掉锁了

remove semver of globby@8
@fengmk2
Copy link
Member

fengmk2 commented Jan 7, 2022

#235

@fengmk2 fengmk2 closed this Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants