Support node 18 (using source-map fork)

[jacobq]

Replaces source-map with @jacobq/source-map to help unblock ember-cli/ember-cli#9905

See also (possibly, but not necessarily, related):

• Switch to faster vlq implementation #14 (addressing that would supersede this)
• See if we can utilize WebAssembly source-map stuff #45 (this PR should only affects VLQ encode/decode stuff, not source mapping in general)

[ef4]

Thanks @jacobq, would you be willing to help get this merged and released?

[jacobq]

Thanks @jacobq, would you be willing to help get this merged and released?

I'm willing to help, but I'm not sure what more is required. I created the source-map fork and made this branch/PR to use it. Is there some particular work that you'd like to see done here?

[ef4]

Thanks, I sent you invites to be a maintainer both here and on NPM.

[jacobq]

@ef4 Do you have a CHANGELOG.md somewhere? Also, any opposition to doing a major bump and dropping node < 16?

[bertdeblock]

@jacobq Do you mean Node < v14? v14 is still in maintenance until 2023-04-30.

[ef4]

There's no existing changelog, it would be great if you want to make one.

As for node versions, just make sure that we don't get ahead of what ember-cli is supporting.

[boris-petrov]

@jacobq also, if this is released as a major version, broccoli-concat won't use it because it requires ^2.1.0 and people won't be able to use Node 18. :)

[jacobq]

@jacobq Do you mean Node < v14? v14 is still in maintenance until 2023-04-30.

My bad (I tend to be a little ruthless about dropping everything older than LTS in my personal projects). Yes, we could actually keep >=12 (for whatwg-url@11), but if 14.x is the oldest still under maintenance then let's go with that. I'll check what ember-cli is doing also.

[jacobq]

@jacobq also, if this is released as a major version, broccoli-concat won't use it because it requires ^2.1.0 and people won't be able to use Node 18. :)

Well, I guess whether or not it is a breaking change depends on whether we change the contract.... I guess I could try to keep 10.x support (rolling back whatwg-url to older version) and keep the release as minor first. Thanks for the feedback.

[boris-petrov]

@jacobq any news on a new (minor) release? :)

[jacobq]

@jacobq any news on a new (minor) release? :)

No, sorry, I am just returning from vacation and have a pile to work through :/
Thanks for the reminder though.