Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false capitalization #530

Merged
merged 2 commits into from Mar 7, 2024
Merged

Fix false capitalization #530

merged 2 commits into from Mar 7, 2024

Conversation

klao
Copy link
Contributor

@klao klao commented Mar 7, 2024

With yaml-1.1 the lib incorrectly parses badly capitalized literals like FALse and OfF as a false value. This PR fixes it.

eemeli
eemeli approved these changes Mar 7, 2024
View reviewed changes
Copy link
Owner

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this!

@eemeli eemeli merged commit 1c6fd6a into eemeli:main Mar 7, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eemeli eemeli eemeli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@klao @eemeli