Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Pair not extend NodeBase; drop its prop forwarding #250

Merged
merged 5 commits into from Apr 1, 2021
Merged

Commits on Mar 28, 2021

  1. feat!: Split flow collections into items in Parser

    BREAKING CHANGE: The shape of FlowCollection items changes from `Token[]`
    to `{ start, key, sep, value }[]`, so that it now matches the items of
    BlockMap and BlockSequence. This means that the corresponding composer
    is completely rewritten.
    eemeli committed Mar 28, 2021
    Copy the full SHA
    37c3ce6 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    e20f5da View commit details
    Browse the repository at this point in the history
  3. fix: Flow comment parsing

    eemeli committed Mar 28, 2021
    Copy the full SHA
    9340ef7 View commit details
    Browse the repository at this point in the history
  4. feat!: Make Pair not extend NodeBase; drop its prop forwarding

    BREAKING CHANGE: While the inheritance of the class is just an
    implementation detail, dropping the prop forwarding means that a user
    that previously set the `commentBefore`, `comment` or `spaceBefore`
    property of a pair will now need to set it for the appropriate key or
    value.
    
    While adjusting the test suite for the changes, the somewhat surprising
    behaviour of multi-line comments on scalar values getting handled as
    `commentBefore` instead of `comment` is also dropped.
    eemeli committed Mar 28, 2021
    Copy the full SHA
    2ead77d View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2021

  1. Copy the full SHA
    bbfffae View commit details
    Browse the repository at this point in the history