Merge sylabs/sif through v2.4.1 #8
Conversation
Bump Go versions used in CI to 1.17 and 1.18. Remove deprecated build constraint format. Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
|
Good catch on the dependabot extra PR. I also independently noticed that and made a separate PR for it apptainer#134, not realizing you had already included it here, so you don't need to include that. Separately, there's a known problem with golangci-lint not working with golang-1.18. It's not particularly urgent for us to upgrade to 1.18, so I plan on waiting for that to be fixed. |
|
The golang-1.18 support was fixed in golangci-lint 1.45, update to that and I think the ci test will succeed |
Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
=======================================
Coverage 76.46% 76.46%
=======================================
Files 28 28
Lines 2503 2503
=======================================
Hits 1914 1914
Misses 450 450
Partials 139 139
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
This pulls in the following PR, bringing apptainer/sif up to the level of v2.4.0