Merge sylabs/sif through v2.11.6-0.20230615203820-9fe9b624c3fd #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add: oci blob support remove unused string * add: oci root index support * update: address pr requests * add: oci opt test * add: flag formatting * update: opts method to handle a reader Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Remove OptOCIBlobMetadata, which required caller to explicitly provide the digest of an OCI blob when creating a DescriptorInput. Calculate the digest automatically as the DataOCIRootIndex/DataOCIBlob data is read. Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Return v1.Hash type directly instead of string. Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #32 +/- ##
=======================================
Coverage ? 72.89%
=======================================
Files ? 35
Lines ? 2955
Branches ? 0
=======================================
Hits ? 2154
Misses ? 646
Partials ? 155
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
DrDaveD
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in the following PRs, bringing apptainer/sif up to the level of v2.11.6-0.20230615203820-9fe9b624c3fd
The original PR descriptions were: