Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge sylabs/sif through v2.11.5 #31

Merged
merged 6 commits into from
Jun 16, 2023
Merged

Merge sylabs/sif through v2.11.5 #31

merged 6 commits into from
Jun 16, 2023

Conversation

edytuk
Copy link
Owner

@edytuk edytuk commented Jun 15, 2023

This pulls in the following PRs, bringing apptainer/sif up to the level of v2.11.5

  • sylabs/sif# 296
  • sylabs/sif# 298
  • sylabs/sif# 299
  • sylabs/sif# 302
  • sylabs/sif# 303
  • sylabs/sif# 304

The original PR descriptions were:

These just started showing up, and are failing. Disabling for now.

Screenshot 2023-05-12 at 3 17 32 PM

Disable depguard, enable forcetypeassert, thelper and new mirror linter.

Restore previous behaviour for makeTestSIF on error.

Building on sylabs/sif# 296, disable Github status updates for now.

Disable 'depguard', enable new 'mirror' linter.

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@ede6a6e). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main      #31   +/-   ##
=======================================
  Coverage        ?   72.80%           
=======================================
  Files           ?       35           
  Lines           ?     2901           
  Branches        ?        0           
=======================================
  Hits            ?     2112           
  Misses          ?      636           
  Partials        ?      153           
Flag Coverage Δ
unittests 72.80% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
* deps: bump github.com/ProtonMail/go-crypto from v0.0.0-20230217124315-7d5c6f04bbb8 to v0.0.0-20230528122434-6f98819771a1

* fix: update test case to match new PGP error

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
@edytuk edytuk requested a review from DrDaveD June 15, 2023 14:09
@DrDaveD DrDaveD merged commit 53f26cc into main Jun 16, 2023
2 checks passed
@edytuk edytuk deleted the v2.11.5 branch June 16, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants