pylint-django plugin issue with wagtail and py38 issue fixed. #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awais786
changed the title
awais786
force-pushed
the
awais786/BOM-1536
branch
from
0bc8e54
to
edb9b98
Compare
awais786
commented
May 7, 2020
| @@ -191,15 +192,15 @@ class ProgramPageBranding(Branding): | |||
| page = ParentalKey(ProgramPage, on_delete=models.CASCADE, related_name='branding', unique=True) | |||
|
|
|||
| cover_image = models.ForeignKey( | |||
| 'wagtailimages.Image', | |||
| Image, | |||
There was a problem hiding this comment.
known issue wagtail/wagtail#5538
awais786
force-pushed
the
awais786/BOM-1536
branch
from
ac181ec
to
02993ef
Compare
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
==========================================
+ Coverage 90.26% 90.35% +0.09%
==========================================
Files 28 28
Lines 842 850 +8
Branches 110 110
==========================================
+ Hits 760 768 +8
Misses 63 63
Partials 19 19
Continue to review full report at Codecov.
|
UsamaSadiq
approved these changes
May 7, 2020
mraarif
approved these changes
May 7, 2020
mzulqarnain1
approved these changes
May 7, 2020
|
@morenol please review. |
awais786
changed the title
morenol
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://openedx.atlassian.net/browse/BOM-1536