Multiline field markdowntable

[BloggerBust-bot]

Depends on: #285

By replacing line-endings found within a field value with an HTML break element, the field value will render with multiple lines in a single table cell, rather than being broken up into multiple table rows.

The only difference between this PR and #285 is in Staticman.js on lines 280 to 282

[VincentTam]

Thanks for PR, even though I don't think this will be merged due to its dependence on #285. Actually, the part that actually does the job is

  Object.keys(fields).forEach(field => {
	    let fieldValue = fields[field]
	    fieldValue = typeof fieldValue === 'string' ? fieldValue.replace(/\r\n/g, '<br>').replace(/\n/g, '<br>') : fieldValue
	    table.push([field, fieldValue])
	  })

https://github.com/eduardoboucas/staticman/pull/289/files#diff-0eb30e85bf25fbc952a68845f6e23860

It is possible that a Staticman v3 user implement this part only without change the rest of the code?

[VincentTam]

Update: I've tested the above code block without the rollback. It works light and right. Bravo ! Here's an example on GitLab.

[BloggerBust-bot]

Update: I've tested the above code block without the rollback. It works light and right. Bravo ! Here's an example on GitLab.

I am glad to hear that you were able to get the fix working :-)

[BloggerBust-bot]

Thanks for PR, even though I don't think this will be merged due to its dependence on #285.

Should I close PR #285? It doesn't seem that it is needed. When I created it, the master branch was broken and that was my way of getting things working again.

It is possible that a Staticman v3 user implement this part only without change the rest of the code?

It looks like you were able to get it working with v3. That is fabulous!

[VincentTam]

Should I close PR #285? It doesn't seem that it is needed. When I created it, the master branch was broken and that was my way of getting things working again.

I can't give a yes/no answer since I haven't tested that. Based on my testing, it seems that #231 doesn't work well with 4eb5ce2, which is included in your PR. I've chosen #231 since that's a continuation of Staticman's GitLab support, which is in fact my main goal of setting up another API instance, as the name "Staticman Lab" suggests. However, it doesn't hurt leaving it there, judging from the feedback from other users in #283.

It looks like you were able to get it working with v3. That is fabulous!

My instances are using the v3 URL scheme, but I'm not merging recent commits on the branches dev and master due to reasons described in #299 (comment). In short, I'm not a great fan of GitHub Apps, and @staticmanlab has to serve site owners affected by #227. Using GitHub Apps would break their "invitation". Moreover, a GitHub App also has its API limit. Finally, the official instances doesn't include support for personal Akismet API #195, so the spamming problem #175 remains unresolved in v3.