Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stricter code checks (TypeScript and Lint) #404

Merged
merged 33 commits into from
Aug 6, 2019
Merged

Conversation

danielweck
Copy link
Member

@danielweck danielweck commented Jul 10, 2019

This PR removes a few any types, removes unused variables, etc. (see linting rules)

Note that strict null/undefined checks are implemented in a separate PR: #475

@danielweck
Copy link
Member Author

@danielweck
Copy link
Member Author

This PR is reasonably consensual, I am hoping we will reach an agreement to merge it.
I created a separate PR for the much less trivial code changes required to achieve strictNullChecks:
#475

@danielweck
Copy link
Member Author

Note that TypeScript 3.6 will provide strongly-typed iterators and generators, which means that the returned values of Redux-Saga yield call() will not have to be typed explicitly. microsoft/TypeScript#31639

@danielweck danielweck changed the title WIP (DO NOT MERGE) stricter code checks (TypeScript and Lint) stricter code checks (TypeScript and Lint) Jul 30, 2019
@danielweck danielweck requested a review from panaC July 30, 2019 00:46
@danielweck
Copy link
Member Author

Hello Pierre @panaC if you have time, I would appreciate your input / review on this PR. The code alterations are mostly lint-related, there are no changes in execution logic. I think that stricter type checking and linting is needed in the Thorium codebase, so that we can continue implementing improvements / refactoring more efficiently.
Thank you! :)

Note that the other PR #475
is much more tricky to integrate (in fact, at this stage, impossible), because of the added strictness for nullable types which breaks compilation. We can ignore this PR for now.

@danielweck danielweck merged commit 52894cc into develop Aug 6, 2019
@danielweck danielweck deleted the feature/stricterCode branch August 6, 2019 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant