Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Work In Progress - CSS refactoring #1571

Closed
wants to merge 82 commits into from

Conversation

danielweck
Copy link
Member

@danielweck danielweck commented Oct 12, 2021

fixes #410
Fixes #1196

@danielweck danielweck requested a review from panaC October 12, 2021 09:37
@danielweck
Copy link
Member Author

@ThibaultENT could you please fix the linting errors:

https://github.com/edrlab/thorium-reader/pull/1571/checks?check_run_id=3868774634

src/renderer/library/components/catalog/AboutThoriumButton.tsx
    58:28 ❌ unexpected trailing whitespace
                                            (EditorConfig trim_trailing_whitespace https://goo.gl/oo8iVb)
src/renderer/library/components/catalog/PublicationAddButton.tsx
    43:19 ❌ unexpected trailing whitespace
                                            (EditorConfig trim_trailing_whitespace https://goo.gl/oo8iVb)
    44:36 ❌ unexpected trailing whitespace
                                            (EditorConfig trim_trailing_whitespace https://goo.gl/oo8iVb)
src/renderer/library/components/opds/OpdsAddForm.tsx
    42:24 ❌ unexpected trailing whitespace
                                            (EditorConfig trim_trailing_whitespace https://goo.gl/oo8iVb)
src/renderer/library/components/settings/KeyboardSettings.tsx
    108:25 ❌ unexpected trailing whitespace       (EditorConfig trim_trailing_whitespace https://goo.gl/oo8iVb)
    111:01 ❌ invalid indent size: 21, expected: 20
                                                    (EditorConfig indent_size              https://goo.gl/QtGB8R)
    125:51 ❌ unexpected trailing whitespace       (EditorConfig trim_trailing_whitespace https://goo.gl/oo8iVb)

Thank you :)

@panaC panaC added this to In progress in 1.8 via automation Oct 15, 2021
@danielweck
Copy link
Member Author

Hello @ThibaultENT I added comments above, do you see them in your GitHub notifications / emails? If not, can you please "subscribe" to this PR? (buttons on the right hand side)

@panaC
Copy link
Member

panaC commented Nov 5, 2021

In reader window, navigation menu now displays rows / stacked items with less spacing:
Screenshot 2021-11-04 at 11 35 40
Screenshot 2021-11-04 at 11 35 15

same issue
image

@panaC
Copy link
Member

panaC commented Nov 5, 2021

image

night mode in develop branch :

image

@panaC
Copy link
Member

panaC commented Nov 5, 2021

image

Blue keyboard focus on thorium :
image

@panaC
Copy link
Member

panaC commented Nov 5, 2021

image

in thorium :

image
image

@danielweck
Copy link
Member Author

As expected, the clickable author/publisher and blue tags works fine, but only in OPDS2 Feedbooks (not OPDS1):

Screenshot 2021-11-05 at 16 49 40

Screenshot 2021-11-05 at 16 50 17

...however I note that the blue tags are clickable in OPDS1, even though they are not actual links (they are “dead”)
Is it possible to remove the “proactive feedback” (mouse hover blue effect and hand mouse cursor) when the tags are not hyperlinks?
(like the author/publishers, etc.)

@danielweck
Copy link
Member Author

danielweck commented Nov 5, 2021

Minor visual "bug" / inconsistency (blue keyboard focus outline):

(Pierre already mentioned this but I wanted to show the different cases)

Screenshot 2021-11-05 at 16 44 05

Screenshot 2021-11-05 at 16 43 32

@danielweck
Copy link
Member Author

Minor issue with clipped / shrunk keyboard outline:

Screenshot 2021-11-05 at 16 59 45

@ThibaultENT
Copy link

As expected, the clickable author/publisher and blue tags works fine, but only in OPDS2 Feedbooks (not OPDS1):

Screenshot 2021-11-05 at 16 49 40 Screenshot 2021-11-05 at 16 50 17

...however I note that the blue tags are clickable in OPDS1, even though they are not actual links (they are “dead”) Is it possible to remove the “proactive feedback” (mouse hover blue effect and hand mouse cursor) when the tags are not hyperlinks? (like the author/publishers, etc.)

Capture d’écran 2021-11-06 à 11 45 40

Ces conditions sont là depuis le début.
→ Dois-je les retirer ?
→ Dois-je remplacer les <span... par des <a onClick... ?

Je rappelle qu'avant non-plus il n'existait pas de lien sur les deux 'else', mais seulement sur la première condition.

@danielweck
Copy link
Member Author

PR superseded by #1589
(NPM/Node upgrade, requires package updates)

@danielweck danielweck closed this Nov 12, 2021
1.8 automation moved this from In progress to Done Nov 12, 2021
danielweck added a commit that referenced this pull request Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
1.8
Done
3 participants