user require syntax for partials #3
Conversation
martell
force-pushed
the
parcel-require-partials
branch
from
6ab8696
to
9a523b5
Compare
There was a problem hiding this comment.
Thanks for the PR. I had seen parcel-bundler/parcel#1732 and was waiting for it to be included in a version release to make the changes. I am pretty excited for it. Once the npm version bumps and includes the update, I'll be happy to accept and merge this.
package.json
Outdated
| @@ -32,7 +32,7 @@ | |||
| "babel-preset-stage-2": "6.24.1", | |||
| "gh-pages": "1.2.0", | |||
| "node-sass": "4.9.0", | |||
| "parcel-bundler": "1.9.4", | |||
| "parcel-bundler": "parcel-bundler/parcel", | |||
There was a problem hiding this comment.
I'd like to wait for the changes to be part of a version release. We'll need to update the version here once that's been done.
src/js/directives.js
Outdated
| @@ -12,7 +10,7 @@ angular | |||
| .directive('navBar', function() { | |||
| return { | |||
| restrict: 'E', | |||
| template: fs.readFileSync('./src/partials/nav.html', 'utf8'), | |||
| template: require('../partials/nav.html', 'utf8'), | |||
There was a problem hiding this comment.
One of the , 'utf8' second parameters got missed.
martell
force-pushed
the
parcel-require-partials
branch
from
9a523b5
to
e7636fb
Compare
martell
force-pushed
the
parcel-require-partials
branch
from
e7636fb
to
8e8c283
Compare
|
I updated the PR to point to what I expect to be the next release version. Thanks for working on this project to give people a good example on how to modernize their old angularjs 1.x apps. |
|
Should this update the migration guide too? It currently shows an example of the prior way to load partials. |
|
@absynce Thanks for checking. Once merged I'll make sure to update the migration guide. You're right, it currently shows use of |
|
Thanks again for the PR. It has been incorporated into #6 so it can get released tonight quickly while I had a few minutes. It was an easy way of handling the merge conflict that came up as well as upgrading another dep and adding the package-lock file. The app is now building with parcel 1.10.1! 🎉 I've also updated the For the wayward reader looking for context, the release of |
|
Support for IE is currently blocked until the html loader handling changes for either:
See #14. |
This is blocked by
parcel-bundler/parcel#1744
which I now have a PR for.
Hopefully we can get this in before v1.9.8
I will update this PR to point to that tag then instead of using the master branch