Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Base.request!/1 return value is not wrapped in a ok-tuple #481

Merged
merged 1 commit into from Nov 24, 2023

Conversation

flambard
Copy link
Contributor

This PR is a fix of the typespec for Base.request!/1. The return value is not supposed to be wrapped in a ok-tuple.

@mjquinlan2000
Copy link

For anyone also affected by dialyzer and waiting for this PR, you can add:

use HTTPoison.Base

@dialyzer {:nowarn_function, request!: 1}

to your modules that use HTTPoison.Base

@edgurgel edgurgel merged commit 0622f80 into edgurgel:main Nov 24, 2023
2 checks passed
@edgurgel
Copy link
Owner

2.2.1 is out! Thanks, team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants