Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin docs dependencies #90

Closed
wants to merge 1 commit into from

Commits on Sep 25, 2022

  1. Unpin docs dependencies

    The sphinx doc build run by CircleCI is currently failing:
    
    ```
    make: Entering directory '/home/circleci/wayback/docs'
    Traceback (most recent call last):
      File "/home/circleci/venv/bin/sphinx-build", line 5, in <module>
        from sphinx.cmd.build import main
      File "/home/circleci/venv/lib/python3.8/site-packages/sphinx/cmd/build.py", line 25, in <module>
        from sphinx.application import Sphinx
      File "/home/circleci/venv/lib/python3.8/site-packages/sphinx/application.py", line 42, in <module>
        from sphinx.registry import SphinxComponentRegistry
      File "/home/circleci/venv/lib/python3.8/site-packages/sphinx/registry.py", line 24, in <module>
        from sphinx.builders import Builder
      File "/home/circleci/venv/lib/python3.8/site-packages/sphinx/builders/__init__.py", line 26, in <module>
        from sphinx.util import import_object, logging, rst, progress_message, status_iterator
      File "/home/circleci/venv/lib/python3.8/site-packages/sphinx/util/rst.py", line 22, in <module>
        from jinja2 import environmentfilter
    ImportError: cannot import name 'environmentfilter' from 'jinja2' (/home/circleci/venv/lib/python3.8/site-packages/jinja2/__init__.py)
    make: *** [Makefile:20: html] Error 1
    make: Leaving directory '/home/circleci/wayback/docs'
    
    Exited with code exit status 2
    
    CircleCI
    ```
    
    It looks like this might be the result of jinja2 imports being
    deprecated?
    
    sphinx-doc/sphinx#10291
    
    I tried unpinning all the dependencies, and making a few minor changes
    to the sphinx config and the docs seem to build fine locally but maybe
    I'm missing some detail about theme/css?
    
    Unfortunately I did have to tell pip to ignore sphinx 5.2.0.post0 which
    appears to have a recent bug that hopefully will be fixed shortly:
    
    readthedocs/sphinx_rtd_theme#1343
    edsu committed Sep 25, 2022
    Configuration menu
    Copy the full SHA
    9f72ff7 View commit details
    Browse the repository at this point in the history