Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new bypassValidation query param to Add/Patch Device API #4797

Merged
merged 2 commits into from
May 7, 2024

Conversation

lindseysimple
Copy link
Contributor

@lindseysimple lindseysimple commented May 7, 2024

Fixes #4789. Add new bypassValidation query param to Add/Patch Device API.

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Fixes edgexfoundry#4789. Add new bypassValidation query param to Add Device API.

Signed-off-by: Lindsey Cheng <beckysocute@gmail.com>
@lindseysimple lindseysimple changed the title Add new bypassValidation query param to Add Device API feat: Add new bypassValidation query param to Add Device API May 7, 2024
cloudxxx8
cloudxxx8 previously approved these changes May 7, 2024
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Lindsey Cheng <beckysocute@gmail.com>
@lindseysimple lindseysimple changed the title feat: Add new bypassValidation query param to Add Device API feat: Add new bypassValidation query param to Add/Patch Device API May 7, 2024
Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 41.65%. Comparing base (971ded0) to head (623d767).

Files Patch % Lines
internal/core/metadata/application/device.go 0.00% 10 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4797      +/-   ##
==========================================
+ Coverage   41.62%   41.65%   +0.03%     
==========================================
  Files         105      105              
  Lines        9858     9868      +10     
==========================================
+ Hits         4103     4111       +8     
- Misses       5402     5404       +2     
  Partials      353      353              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cloudxxx8
Copy link
Member

recheck

@cloudxxx8 cloudxxx8 merged commit 17930b1 into edgexfoundry:main May 7, 2024
6 checks passed
@cloudxxx8 cloudxxx8 deleted the issue-4789 branch May 7, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add bypassValidation query parameter for POST Device API
3 participants