Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite "chain of trust" section #3066

Merged
merged 9 commits into from
May 27, 2024
Merged

Rewrite "chain of trust" section #3066

merged 9 commits into from
May 27, 2024

Conversation

flxflx
Copy link
Member

@flxflx flxflx commented May 6, 2024

I rewrote the "Chain of trust" section to explain E2E how trust is established into a cluster. This is the first step of rewriting the entire attestation.md and potentially other parts of the docs.

@flxflx flxflx requested a review from thomasten as a code owner May 6, 2024 16:05
Copy link

netlify bot commented May 6, 2024

Deploy Preview for constellation-docs ready!

Name Link
🔨 Latest commit b7bee5b
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/6654af4713ec930008119fa5
😎 Deploy Preview https://deploy-preview-3066--constellation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flxflx flxflx requested review from m1ghtym0 and malt3 and removed request for thomasten May 6, 2024 16:10
Copy link
Member

@m1ghtym0 m1ghtym0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reads much clearer now, thanks!
Not sure why vale is unhappy with "CLI's" and was happy with "CLI" before.
Maybe we need to add "CLI" to https://github.com/edgelesssys/constellation/blob/main/docs/styles/config/vocabularies/edgeless/accept.txt#L14

docs/docs/architecture/attestation.md Outdated Show resolved Hide resolved
docs/docs/architecture/attestation.md Outdated Show resolved Hide resolved
docs/docs/architecture/attestation.md Outdated Show resolved Hide resolved
@flxflx flxflx requested a review from 3u13r May 7, 2024 12:05

When a cluster is [created](../workflows/create.md), the CLI automatically verifies the runtime measurements of the *first node* using remote attestation. Based on this, the CLI and the first node set up a temporary TLS connection. This [aTLS](#attested-tls-atls) connection is used for three things:
1. The CLI sends the runtime measurements for the applicable node image to the first node.
2. The first node sends the [master secret](../architecture/keys.md#master-secret) of the to-be-created cluster to the CLI. The master secret is generated by the first node.
Copy link
Contributor

@malt3 malt3 May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this works the other way around CC @daniel-weisse.

MasterSecret uri.MasterSecret

In the init grpc proto, this field is called kms_uri.

// KmsUri is an URI encoding access to the KMS service or master secret.
string kms_uri = 1;

The CLI generates the master secret and sends it to the first node.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally we generated the master secret on node, we no longer do this, so it should be
"The CLI sends the master secret to the first node"

Technically, we also send the runtime measurements to the first node later on once the Kubernetes is actually set up,.
Though at this point only a single node cluster exists, so the statement is still correct.

Its called kms_uri in the proto definition since we encode the secret in a URI to make it compatible with a yet-to-be-implemented KMS backend to keep and manage the secret

Copy link
Member

@3u13r 3u13r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When Malte's comment is addressed: LGTM

Copy link
Contributor

@malt3 malt3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise

@m1ghtym0 m1ghtym0 merged commit 7197a9b into main May 27, 2024
7 checks passed
@m1ghtym0 m1ghtym0 deleted the flx-docs branch May 27, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants