bootstrapper: override Cilium MTU auto-detection on GCP (requires Cilium 1.13.0) #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nirusu
added
bug fix
Nirusu
force-pushed
the
fix/mtu-e2e
branch
4 times, most recently
from
eef44f6
to
2e816b7
Compare
|
Just a heads-up: This branch should be rebased before merge and bazel build files should be generated. |
|
Rebased. Gazelle should be happy without any changes since I didn't touch any imports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
This should fix the issues with benchmarking in the CI, where Cilium picks up the MTU from Podman.
On normal deployments this should not be an issue so far.
This requires Cilium 1.13.0 as the MTU value does not exist in Helm before, see: cilium/cilium#20639
This workaround could be way easier by hardcoding the network interface to
ens3. However, not sure if Google will ever change that in the future, so let's just to it the tedious way I presume.Draft for now since we need to upgrade to Cilium 1.13.0 first.
Related issue
Checklist