Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update rules_proto to v5.3.0 #1204

Closed
wants to merge 1 commit into from
Closed

Conversation

malt3
Copy link
Contributor

@malt3 malt3 commented Feb 16, 2023

Upstream release: https://github.com/bazelbuild/rules_proto/releases/tag/5.3.0-21.7

Proposed change(s)

  • update rules_proto to v5.3.0

Related issue

Additional info

  • Breaks build on NixOS since protoc is not hermetic.
  • We should not merge this and instead upgrade to the next release with static protoc.

Checklist

  • Update docs
  • Add labels (e.g., for changelog category)
  • Link to Milestone

@netlify
Copy link

netlify bot commented Feb 16, 2023

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 4b215e9
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/63edfe054bd65e00087e2f15

@malt3 malt3 added the hold This cannot be merged right now label Mar 15, 2023
@katexochen katexochen removed their request for review June 15, 2023 12:58
@katexochen katexochen added the dependencies Pull requests that update a dependency file label Sep 26, 2023
@malt3
Copy link
Contributor Author

malt3 commented Jan 9, 2024

We need to wait for the next release of rules_proto, so the protoc binary is statically linked. See this failed attempt: bazelbuild/rules_proto#168

What's really missing is for rules_proto and protobuf to gain upstream bzlmod support, so they can actually release new versions. TL:DR: We are blocked on protocolbuffers/protobuf#14564

@malt3
Copy link
Contributor Author

malt3 commented May 16, 2024

rules_proto has a new toolchain design and new releases do ship with statically linked protoc: https://github.com/bazelbuild/rules_proto/releases/tag/6.0.0

However, upgrading is still blocked by other dependencies not being compatible with this new major version of the ruleset.

This was one of the issues I observed when trying to upgrade:

bazelbuild/rules_proto#212

@malt3 malt3 closed this May 24, 2024
@daniel-weisse daniel-weisse deleted the deps/rules_proto/5.3.0 branch May 24, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file hold This cannot be merged right now
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants