Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency jose to 2.0.6 [security] - abandoned #217

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 16, 2022

Mend Renovate

This PR contains the following updates:

Package Change
jose 2.0.5 -> 2.0.6

GitHub Vulnerability Alerts

CVE-2022-36083

The PBKDF2-based JWE key management algorithms expect a JOSE Header Parameter named p2c (PBES2 Count), which determines how many PBKDF2 iterations must be executed in order to derive a CEK wrapping key. The purpose of this parameter is to intentionally slow down the key derivation function in order to make password brute-force and dictionary attacks more expensive.

This makes the PBES2 algorithms unsuitable for situations where the JWE is coming from an untrusted source: an adversary can intentionally pick an extremely high PBES2 Count value, that will initiate a CPU-bound computation that may take an unreasonable amount of time to finish.

Impact

Under certain conditions (see below) it is possible to have the user's environment consume unreasonable amount of CPU time.

Affected users

The impact is limited only to users utilizing the JWE decryption APIs with symmetric secrets to decrypt JWEs from untrusted parties who do not limit the accepted JWE Key Management Algorithms (alg Header Parameter) using the keyManagementAlgorithms (or algorithms in v1.x) decryption option or through other means.

The PBKDF2-based JWE Key Management Algorithm Identifiers are

  • PBES2-HS256+A128KW
  • PBES2-HS384+A192KW
  • PBES2-HS512+A256KW

e.g.

const secret = new Uint8Array(16)
const jwe = '...' // JWE from an untrusted party

await jose.compactDecrypt(jwe, secret)

You are NOT affected if any of the following applies to you

  • Your code does not use the JWE APIs
  • Your code only produces JWE tokens
  • Your code only decrypts JWEs using an asymmetric JWE Key Management Algorithm (this means you're providing an asymmetric key object to the JWE decryption API)
  • Your code only accepts JWEs produced by trusted sources
  • Your code limits the accepted JWE Key Management Algorithms using the keyManagementAlgorithms decryption option not including any of the PBKDF2-based JWE key management algorithms

Patches

v1.28.2, v2.0.6, v3.20.4, and v4.9.2 releases limit the maximum PBKDF2 iteration count to 10000 by default. It is possible to adjust this limit with a newly introduced maxPBES2Count decryption option.

Workarounds

All users should be able to upgrade given all stable semver major release lines have had new a patch release introduced which limits the PBKDF2 iteration count to 10000 by default. This removes the ability to craft JWEs that would consume unreasonable amount of CPU time.

If users are unable to upgrade their required library version they have two options depending on whether they expect to receive JWEs using any of the three PBKDF2-based JWE key management algorithms.

  • they can use the keyManagementAlgorithms decryption option to disable accepting PBKDF2 altogether
  • they can inspect the JOSE Header prior to using the decryption API and limit the PBKDF2 iteration count (p2c Header Parameter)

For more information

If you have any questions or comments about this advisory:


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Sep 16, 2022
@github-actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 3.3%, saving 57.17 KB.

Filename Before After Improvement Visual comparison
template/public/img/uploads/banner_domi_mobile.webp 35.27 KB 34.83 KB -1.2% View diff
template/public/img/uploads/banner_hard1.webp 116.16 KB 113.99 KB -1.9% View diff
template/public/img/uploads/banner_hard2.webp 128.78 KB 127.34 KB -1.1% View diff
template/public/img/uploads/banner-quadrado.jpg 141.74 KB 132.46 KB -6.5% View diff
template/public/img/uploads/banner-quadrado.webp 82.03 KB 76.23 KB -7.1% View diff
template/public/img/uploads/banner-site.jpg 115.67 KB 108.22 KB -6.4% View diff
template/public/img/uploads/banner-site.webp 67.36 KB 60.91 KB -9.6% View diff
template/public/img/uploads/frete_gratis_full.webp 84.83 KB 83.56 KB -1.5% View diff
template/public/img/uploads/frete_gratis_mobile.webp 83.96 KB 82.66 KB -1.5% View diff
template/public/img/uploads/linha_dark-1.webp 54.54 KB 53.47 KB -2.0% View diff
template/public/img/uploads/linha_dark-2.webp 58.50 KB 57.41 KB -1.9% View diff
template/public/img/uploads/lov_banner_site-diadosnamorados.webp 80.50 KB 79.47 KB -1.3% View diff
template/public/img/uploads/lov_bannerssite-fireice-quadrado.webp 172.29 KB 164.79 KB -4.4% View diff
template/public/img/uploads/lov_bannerssite-fireice-retangular-site.webp 135.49 KB 133.33 KB -1.6% View diff
template/public/img/uploads/lov_post1-novosite1.webp 72.00 KB 70.84 KB -1.6% View diff
template/public/img/uploads/lov-banner-presentes-joias-site-.webp 68.42 KB 67.63 KB -1.2% View diff
template/public/img/uploads/lov-posts-presentes-joias-site.webp 63.15 KB 62.27 KB -1.4% View diff
template/public/img/uploads/selo_google.webp 1.61 KB 1.57 KB -2.4% View diff
template/public/img/uploads/vibre_1.webp 67.15 KB 65.25 KB -2.8% View diff
template/public/img/uploads/vibre_2.webp 78.40 KB 74.46 KB -5.0% View diff

55 images did not require optimisation.

@renovate
Copy link
Contributor Author

renovate bot commented Nov 28, 2022

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@renovate renovate bot changed the title chore(deps): update dependency jose to 2.0.6 [security] chore(deps): update dependency jose to 2.0.6 [security] - abandoned Dec 23, 2022
@renovate
Copy link
Contributor Author

renovate bot commented Dec 23, 2022

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants