Provide a JvmGenericTypeValidator #3031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e5d2970.
When the language automatically adds a supertype
|
@szarnekow I also added the commented |
szarnekow
approved these changes
May 16, 2024
|
This is indeed an appreciated improvement for standard Xbase languages. Well done! |
This was referenced May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2349
This is my proposal for a
JvmGenericTypeValidator, containing code extracted and refactored from XtendValidator for typical inheritance-based checks on the inferred Jvm model for Xbase languages. This is an opt-in feature, to be enabled through a composed validator.This has been tested through Xtend, which is now using it, and a testlanguage for some corner cases (https://github.com/eclipse/xtext/compare/main...LorenzoBettini:xtext:lb_2349?expand=1#diff-25aca6d3c766f0d3e06a3fd1d893c1d3e3dc23b7e503b3facabffbd1e3e882f9).
The Xtend tests have been updated when I thought they would be improved according to the introduced JvmGenericTypeValidator. As for the rest, the results are the same. Note that Xtend customizes such a validator for a few special cases.
This validator has been applied to Domainmodel ef578b5 and the corresponding Entities web example 08b5090
@szarnekow please let me know if I can provide further details to help the review.