Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor MessageID Mutex #602

Merged
merged 2 commits into from Aug 1, 2022
Merged

Refactor MessageID Mutex #602

merged 2 commits into from Aug 1, 2022

Commits on Jul 31, 2022

  1. Refactor messageIds mutex (no longer anonymous) 

    As client embeds both messageIds, and an RWMutex, anonymously it was not obvious if calling `c.RLock()` accessed the directly embedded mutex or the one in messageIds. Changing this simplifies future refactoring.
    @MattBrittan
    MattBrittan committed Jul 31, 2022
    Copy the full SHA
    09afcd9 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2022

  1. Fix tests (including removing one instance of t.FatalF from a go rout… 

    …ine)
    @MattBrittan
    MattBrittan committed Aug 1, 2022
    Copy the full SHA
    ccb7d1c View commit details
    Browse the repository at this point in the history