Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disconnect refactor #586

Merged
merged 3 commits into from Mar 13, 2022
Merged

Disconnect refactor #586

merged 3 commits into from Mar 13, 2022

Commits on Feb 11, 2022

  1. client: set disconnect as defer 

    This makes it easy to refactor the conditional and makes sure
that it always gets executed.
    @ptsneves
    ptsneves committed Feb 11, 2022
    Copy the full SHA
    7254d2c View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2022

  1. client: refactor setConnected(disconnected) out of conditional 

    c.setConnected(disconnected) was called inconditionally in both
conditions start so it is in fact independent of the status. Move
it out.
    @ptsneves
    ptsneves committed Mar 10, 2022
    Copy the full SHA
    3ec7db3 View commit details
    Browse the repository at this point in the history

  2. client: localized disconnectSent logic 

    the diconnectSent logic was being used in it's own conditional when
it naturally is not conditional when the writing to c.ouboundP is
successful.

Signed-off-by: Paulo Neves <ptsneves@gmail.com>
    @ptsneves
    ptsneves committed Mar 10, 2022
    Copy the full SHA
    ac29fdf View commit details
    Browse the repository at this point in the history