Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add github actions builds #169

Closed
wants to merge 3 commits into from
Closed

add github actions builds #169

wants to merge 3 commits into from

Conversation

sebthom
Copy link
Member

@sebthom sebthom commented Jun 29, 2022

No description provided.

@mickaelistria
Copy link
Contributor

At the moment, we're satisfied with Jenkins builds. What value would this extra build offer that makes it worth the extra maintenance?

@sebthom
Copy link
Member Author

sebthom commented Jun 30, 2022

  1. When working in a fork the jenkins jobs are not running, so there is no CI feedback without creating a PR to the source repo. If we have gha configured they also run in forked repos.
  2. From my experience with the TM4E project GHA builds seem faster (i.e. shorter feedback loop).
  3. In case of failing builds going through the logs in GHA feels more efficient and faster (Jenkins UI seems to render considerably slower).
  4. Build stability in GHA for some reason seems to be better than in Jenkins (experience from the TM4E project), i. e. fewer random build failures. So if a build fails only in Jenkins and not in GHA it gives a better indication whether there is actual a bug introduced by a commit or if there may just be an infrastructure issue with Jenkins.

@sebthom sebthom force-pushed the patch-10 branch 2 times, most recently from 12d5158 to a837904 Compare June 30, 2022 12:47
@sebthom sebthom marked this pull request as draft June 30, 2022 12:48
@sebthom sebthom marked this pull request as draft June 30, 2022 12:48
@sebthom sebthom force-pushed the patch-10 branch 4 times, most recently from 19ebd0b to e7bcdbc Compare June 30, 2022 13:17
@sebthom sebthom marked this pull request as ready for review June 30, 2022 13:25
@rubenporras
Copy link
Contributor

for what is worth, I also think like Sebastian that it would be very nice to CI feedback without creating a PR to the source repo. Usually I create a PR just to get the CI feedback, even when changes are not ready.

org.eclipse.lsp4e.jdt/META-INF/MANIFEST.MF Outdated Show resolved Hide resolved
org.eclipse.lsp4e.debug/META-INF/MANIFEST.MF Outdated Show resolved Hide resolved
org.eclipse.lsp4e.tests.mock/META-INF/MANIFEST.MF Outdated Show resolved Hide resolved
LICENSE Outdated Show resolved Hide resolved
@sebthom sebthom force-pushed the patch-10 branch 2 times, most recently from 3766c26 to a60c0a1 Compare July 5, 2022 15:40
@sebthom sebthom marked this pull request as draft July 5, 2022 15:47
@sebthom sebthom marked this pull request as draft July 5, 2022 15:47
@sebthom sebthom force-pushed the patch-10 branch 2 times, most recently from 791b5fe to 984afe2 Compare July 31, 2022 19:06
@sebthom
Copy link
Member Author

sebthom commented Jul 31, 2022

@rubenporras I am getting test failures in github builds. Any ideas why? https://github.com/sebthom/lsp4e/runs/7600681404?check_suite_focus=true I am using a similar github action config for building/testing TM4E where it works fine.

@sebthom sebthom force-pushed the patch-10 branch 8 times, most recently from 630d8ec to 6d784b7 Compare October 25, 2022 10:55
@sebthom sebthom marked this pull request as ready for review May 18, 2024 14:15
@sebthom
Copy link
Member Author

sebthom commented May 18, 2024

I spent a lot of time trying to get the jobs running without test failures on Windows and Ubuntu but so far there are still random test failures. Only MacOS builds are stable so I configured tests on Windows/Ubuntu runners with continue-on-error=true for now until we find a way to stabilize the tests. Even with only mac builds I think this is a valuable addition. So this PR is ready to be merged.

@sebthom sebthom requested a review from rubenporras May 18, 2024 14:18
@mickaelistria
Copy link
Contributor

The initial target branch master was deleted and replaced by main, so this PR got closed automatically. If this is still relevant, please re-create this PR targetting the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants