Fix docker image tagging in jenkins #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Schildt <sebastian.schildt@de.bosch.com>
Signed-off-by: Sebastian Schildt <sebastian.schildt@de.bosch.com>
Signed-off-by: Sebastian Schildt <sebastian.schildt@de.bosch.com>
wenwenchenbosch
approved these changes
Aug 25, 2020
|
Mergeable @rohoet Thx. |
erikbosch
pushed a commit
to erikbosch/kuksa.val
that referenced
this pull request
Oct 20, 2023
…-jenkins Fix docker image tagging in jenkins
erikbosch
pushed a commit
to boschglobal/kuksa.val
that referenced
this pull request
Oct 26, 2023
…-jenkins Fix docker image tagging in jenkins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our "production" dockers did not have tags attached when "loading" them, because we saved them basing on SHA Hash (see here moby/moby#3877 )
This has been fixed.
Also the docu was missing to expose a port.
@wenwenchenbosch This fix couldn't possibly go wrong, but pls. check if it still builds/works for you 😄