Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log or throw exception if DefaultSessionIdManager is used but has not been started. #8460

Closed
janbartel opened this issue Aug 14, 2022 · 0 comments · Fixed by #8464
Closed

Log or throw exception if DefaultSessionIdManager is used but has not been started. #8460

janbartel opened this issue Aug 14, 2022 · 0 comments · Fixed by #8464
Labels
Bug For general bugs on Jetty side

Comments

@janbartel
Copy link
Contributor

Add a check for being started to the DefaultSessionIdManager and either log or throw an exception if it is not started. This will avoid an NPE when a session is serialized if a non-started DefaultSessionIdManager is used to generate the session ids.
@janbartel janbartel added the Bug For general bugs on Jetty side label Aug 14, 2022
janbartel added a commit that referenced this issue Aug 15, 2022
@janbartel
Issue #8460 check DefaultSessionIdManager is started
32b91b4
@janbartel janbartel mentioned this issue Aug 15, 2022
Merged
janbartel added a commit that referenced this issue Nov 23, 2022
@janbartel
Issue #8460 simplify DefaultSessionIdManager start (#8464)
cd7482a 
* Issue #8460 check DefaultSessionIdManager is started
janbartel added a commit that referenced this issue Nov 23, 2022
@janbartel
Issue #8460 simplify DefaultSessionIdManager start (#8464)
c4e1db5 
* Issue #8460 check DefaultSessionIdManager is started
@olamy olamy mentioned this issue Dec 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For general bugs on Jetty side
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #8460 simplify DefaultSessionIdManager start jetty/jetty.project
1 participant
@janbartel