unwrap exception until we get the first non ServletException, as this can be wrap of wrap of wrap when using ContextHandlerCollection #7803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olamy
force-pushed
the
jetty-11.0.x-servlet-exception-recursive-unwrap
branch
from
a68d3b8
to
c8102a5
Compare
… can be wrap of wrap of wrap when using ContextHandlerCollection Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
olamy
force-pushed
the
jetty-11.0.x-servlet-exception-recursive-unwrap
branch
from
154fd57
to
f251735
Compare
|
I wonder if we should make unwrap true per default as it is expected by servlet spec? |
joakime
approved these changes
Mar 30, 2022
This was referenced Jul 25, 2022
Merged
51 tasks
olamy
added a commit
that referenced
this pull request
Oct 13, 2022
Signed-off-by: Olivier Lamy <olamy@apache.org>
olamy
added a commit
that referenced
this pull request
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TCK test fail when using some embedded Jetty
Signed-off-by: Olivier Lamy oliver.lamy@gmail.com