Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetty Jaspi module not compatible with Jakarta EE 9 (Jakarta Authentication) #6406

Closed
frode-carlsen opened this issue Jun 13, 2021 · 3 comments · Fixed by #6412
Closed

Jetty Jaspi module not compatible with Jakarta EE 9 (Jakarta Authentication) #6406

frode-carlsen opened this issue Jun 13, 2021 · 3 comments · Fixed by #6412
Labels
Bug For general bugs on Jetty side

Comments

@frode-carlsen
Copy link
Contributor

Jetty version(s)
11.0.3

Java version/vendor (use: java -version)
16.0.1
OS type/version
Windows 10

Description

jetty-jaspi module in 11.0.3 relies on old geronimo-jaspi 2.0.0 and javax.xml.bind:jaxb-api:2.3.1
This relies on looking up the javax.security.auth.message.config.AuthConfigFactory instead of the JakartaEE 9 Jakarta Authentication jakarta.security.auth.message.config.AuthConfigFactory, and therefore fails to load any Jakarta Authentication modules (ServerAuthModule)

How to reproduce?
Configure and run a Jakarta Authentication EE 9 compatible ServerAuthModule.
@frode-carlsen frode-carlsen added the Bug For general bugs on Jetty side label Jun 13, 2021
@janbartel
Copy link
Contributor

We'd be delighted to review a pull request if you were to submit one.

@frode-carlsen
Copy link
Contributor Author

Ok, I've created a PR for this here:
#6412

@joakime joakime linked a pull request Jun 15, 2021 that will close this issue
Issue #6406 - port jetty-jaspi to use Jakarta Authentication 2.x #6412
Merged
lachlan-roberts added a commit that referenced this issue Jul 28, 2021
@lachlan-roberts
Issue #6406 - update documentation for JASPI, & changes from review
9c802fe 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Aug 2, 2021
@lachlan-roberts
Issue #6406 - add documentation for use of custom AuthConfigFactories
4e7955d 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Aug 2, 2021
@lachlan-roberts
Issue #6406 - fix xml directory path mentioned in JASPI documentation
3bce624 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Aug 2, 2021
@lachlan-roberts
Issue #6406 - move JaspiConfiguration into jetty-jaspi module
ae455ff 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Aug 2, 2021
@lachlan-roberts
Issue #6406 - fix how jetty-demo.xml is displayed in documentation
bc67194 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Aug 12, 2021
@lachlan-roberts
Issue #6406 - update documentation for JASPI, & changes from review
5346d8b 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Aug 12, 2021
@lachlan-roberts
Issue #6406 - add documentation for use of custom AuthConfigFactories
5ba2b2b 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Aug 12, 2021
@lachlan-roberts
Issue #6406 - fix xml directory path mentioned in JASPI documentation
515f384 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Aug 12, 2021
@lachlan-roberts
Issue #6406 - move JaspiConfiguration into jetty-jaspi module
5e4a279 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Aug 12, 2021
@lachlan-roberts
Issue #6406 - fix how jetty-demo.xml is displayed in documentation
b06ff0b 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Aug 13, 2021
@lachlan-roberts
Issue #6406 - JaspiConfiguration now checks availability of JaspiAuth…
d0e02ae 
…enticator

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
janbartel pushed a commit that referenced this issue Aug 18, 2021
@frode-carlsen @lachlan-roberts
Issue #6406 - port jetty-jaspi to use Jakarta Authentication 2.x (#6412)
4448bc0 
* Issue #6406 - port jetty-jaspi to use Jakarta Authentication 2.x, removed test dependency on old Geronomi-jaspi

Co-authored-by: Lachlan Roberts <lachlan@webtide.com>
@janbartel
Copy link
Contributor

@frode, merged #6412. Thank you for all your work on this one!

lachlan-roberts added a commit that referenced this issue Aug 20, 2021
@frode-carlsen @lachlan-roberts
Issue #6406 - port jetty-jaspi to use Jakarta Authentication 2.x (#6412)
7ed37f0 
* Issue #6406 - port jetty-jaspi to use Jakarta Authentication 2.x, removed test dependency on old Geronomi-jaspi

Co-authored-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts mentioned this issue Aug 20, 2021
Merged
lachlan-roberts added a commit that referenced this issue Aug 27, 2021
@lachlan-roberts @frode-carlsen
Issue #6406 - backport jetty-jaspi changes to 10.0.x
4d579d6 
Co-authored-by: Frode Carlsen <frode.odde.carlsen@nav.no>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Aug 27, 2021
@lachlan-roberts
Merge pull request #6649 from eclipse/jetty-10.0.x-jetty-jaspi
f10ae7c 
Issue #6406 - backport of jetty-jaspi changes to jetty-10 (#6412)
@olamy olamy mentioned this issue Sep 30, 2021
Merged
@olamy olamy mentioned this issue May 6, 2022
Merged
@olamy olamy mentioned this issue May 26, 2022
Merged
This was referenced Jul 25, 2022
Merged
Merged
Merged
@olamy olamy mentioned this issue Aug 13, 2022
Merged
@olamy olamy mentioned this issue Dec 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For general bugs on Jetty side
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #6406 - port jetty-jaspi to use Jakarta Authentication 2.x
2 participants
@frode-carlsen @janbartel