Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review osgi manifests within Jetty 10 #6394

Closed
joakime opened this issue Jun 10, 2021 · 1 comment · Fixed by #6408
Closed

Review osgi manifests within Jetty 10 #6394

joakime opened this issue Jun 10, 2021 · 1 comment · Fixed by #6408
Assignees
Labels
Bug For general bugs on Jetty side

Comments

@joakime
Copy link
Contributor

joakime commented Jun 10, 2021

Jetty version
10.0.5

Description
During the work for the slf4j osgi manifest on PR #6381 it was noticed that some other osgi manifest entries are a bit out of date and should be reviewed.

https://github.com/eclipse/jetty.project/blob/6dea0251c2a4948578092db1c81e0d33b06f95b9/jetty-annotations/pom.xml#L33

We are at ASM 9 on Jetty 10

https://github.com/eclipse/jetty.project/blob/6dea0251c2a4948578092db1c81e0d33b06f95b9/jetty-osgi/test-jetty-osgi-context/pom.xml#L78-L79

and

https://github.com/eclipse/jetty.project/blob/6dea0251c2a4948578092db1c81e0d33b06f95b9/jetty-osgi/test-jetty-osgi-server/pom.xml#L70-L71

We are at Javax Servlet 4 on Jetty 10

@joakime joakime added the Bug For general bugs on Jetty side label Jun 10, 2021
@janbartel
Copy link
Contributor

The jetty-annotations pom could be updated to a minimum of asm 9, but the other 2 are test webapps so ok to leave at a minimum of 3.1 but could be updated to a max version of 5.

janbartel added a commit that referenced this issue Jun 15, 2021
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel added a commit that referenced this issue Jun 17, 2021
Signed-off-by: Jan Bartel <janb@webtide.com>
@janbartel janbartel added this to To do in Jetty 10.0.6/11.0.6 FROZEN via automation Jun 17, 2021
janbartel added a commit that referenced this issue Jun 21, 2021
Signed-off-by: Jan Bartel <janb@webtide.com>
@lachlan-roberts lachlan-roberts moved this from To do to Done in Jetty 10.0.6/11.0.6 FROZEN Jun 23, 2021
@joakime joakime changed the title Review osgi manifest for Jetty 10 Review osgi manifests within Jetty 10 Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants