Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CyclicTimeout for HTTP2Streams #6251

Closed
sbordet opened this issue May 10, 2021 · 1 comment · Fixed by #6267
Closed

Use CyclicTimeout for HTTP2Streams #6251

sbordet opened this issue May 10, 2021 · 1 comment · Fixed by #6267
Assignees
@sbordet
Projects
Jetty 10.0.3/11.0.3

Comments

@sbordet
Copy link
Contributor

sbordet commented May 10, 2021

Jetty version
10.0.x

Description
HTTP2Stream inherits from IdleTimeout, but most of the times its timeout is never enforced, as the stream completes before the timeout expires.

Use CyclicTimeout instead of IdleTimeout.
@sbordet
Copy link
Contributor Author

sbordet commented May 10, 2021

See also #2002.

@sbordet sbordet self-assigned this May 10, 2021
sbordet added a commit that referenced this issue May 12, 2021
@sbordet
Fixes #6251 - Use CyclicTimeout for HTTP2Streams.
37f7634 
Introduced CyclicTimeouts to manage many entities that may timeout.
Rewritten HttpDestination request timeouts using CyclicTimeouts.
HTTP2Stream does not inherit from IdleTimeout anymore; now a
CyclicTimeouts in HTTP2Session manages the stream timeouts.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet linked a pull request May 12, 2021 that will close this issue
Fixes #6251 - Use CyclicTimeout for HTTP2Streams. #6267
Merged
sbordet added a commit that referenced this issue May 13, 2021
@sbordet
Issue #6251 - Use CyclicTimeout for HTTP2Streams.
7d203e1 
Updates after review.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet added a commit that referenced this issue May 14, 2021
@sbordet
Issue #6251 - Use CyclicTimeout for HTTP2Streams.
daa4bf5 
Fixed javadocs.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet added a commit that referenced this issue May 16, 2021
@sbordet
Fixes #6251 - Use CyclicTimeout for HTTP2Streams. (#6267)
27db8ed 
* Fixes #6251 - Use CyclicTimeout for HTTP2Streams.

Introduced CyclicTimeouts to manage many entities that may timeout.
Rewritten HttpDestination request timeouts using CyclicTimeouts.
HTTP2Stream does not inherit from IdleTimeout anymore; now a
CyclicTimeouts in HTTP2Session manages the stream timeouts.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet added this to To do in Jetty 10.0.3/11.0.3 via automation May 19, 2021
@sbordet sbordet moved this from To do to Done in Jetty 10.0.3/11.0.3 May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbordet sbordet

Labels
None yet
Projects
No open projects
Jetty 10.0.3/11.0.3
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #6251 - Use CyclicTimeout for HTTP2Streams. jetty/jetty.project
1 participant
@sbordet