Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to manage start modules by java feature #5492

Closed
joakime opened this issue Oct 22, 2020 · 1 comment · Fixed by #5494
Closed

Add ability to manage start modules by java feature #5492

joakime opened this issue Oct 22, 2020 · 1 comment · Fixed by #5494
Labels
Enhancement Stale For auto-closed stale issues and pull requests

Comments

@joakime
Copy link
Contributor

joakime commented Oct 22, 2020

Jetty version
9.4.x

Description
When writing optional modules that depend on Java features (like alpn or loom) you currently have to rely on the ${java.version.platform} start property.
Which means you wind up having multiple *.mod files, one for each major version of java, just to enable/disable modules based on a feature in java.

Proposal is to add new "features" properties to start.jar

aka:

// features built into java.
properties.setProperty("java.feature.alpn", Boolean.toString(ver.getPlatform() >= 9), source);
properties.setProperty("java.feature.jpms", Boolean.toString(ver.getPlatform() >= 9), source);
properties.setProperty("java.feature.loom", Boolean.toString(ver.getPlatform() >= 16), source);

That way we can simplify the maintenance of optional modules.

@joakime joakime added this to To do in Jetty 9.4.34 via automation Oct 22, 2020
joakime added a commit that referenced this issue Oct 22, 2020
+ Simplifying alpn start modules in the process.
  (from 11 to 3)

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime linked a pull request Oct 22, 2020 that will close this issue
@joakime joakime moved this from To do to In progress in Jetty 9.4.34 Oct 22, 2020
@gregw gregw removed this from In progress in Jetty 9.4.34 Nov 2, 2020
joakime added a commit that referenced this issue Feb 15, 2021
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Feb 15, 2021
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Feb 18, 2021
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Feb 18, 2021
…start-properties

Issue #5492 - Adding java.features.* start properties
This was referenced Mar 10, 2021
This was referenced Mar 10, 2021
@github-actions
Copy link

This issue has been automatically marked as stale because it has been a
full year without activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the Stale For auto-closed stale issues and pull requests label Dec 12, 2021
@joakime joakime closed this as completed Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Stale For auto-closed stale issues and pull requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant