Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use interpolation of versions from pom in mod files #3514

Closed
olamy opened this issue Apr 1, 2019 · 10 comments · Fixed by #6839
Closed

Use interpolation of versions from pom in mod files #3514

olamy opened this issue Apr 1, 2019 · 10 comments · Fixed by #6839
Assignees
@olamy
Labels
Build Test
Projects
Jetty 10.0.7/11.0.7 FROZEN
Milestone
10.0.x

Comments

@olamy
Copy link
Member

olamy commented Apr 1, 2019

Currently all mod files have a hardcoded version of libraries we used. So they can be out dated compared from version we use in test because require some manual changes.
We can can use maven interpolation to get the exact same version as used in test and declared in poms
@olamy olamy self-assigned this Apr 1, 2019
@olamy olamy added this to the 9.4.x milestone Apr 1, 2019
olamy added a commit to jetty/jetty-toolchain that referenced this issue Apr 1, 2019
@olamy
part of jetty/jetty.project#3514 to use directories with interpolated…
31f9507 
… files

Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
olamy added a commit that referenced this issue Apr 1, 2019
@olamy
Issue #3514 using interpolation for mod files, fix unix socket mod fi…
4ad77b5 
…les with adding a distribution test

Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
@joakime
Copy link
Contributor

joakime commented Apr 1, 2019

seems like a duplicate of #315

@olamy
Copy link
Member Author

olamy commented Apr 1, 2019 •
edited

@joakime good point! except my current changes do not include managing transitive dependencies. Should we? (this will need more work)

@joakime
Copy link
Contributor

joakime commented Apr 1, 2019

@olamy you might want to take a look at https://github.com/eclipse/jetty.project/blob/jetty-9.4.x/jetty-gcloud/jetty-gcloud-session-manager/

That's the big one, and the process we came up with in there is kinda noisy.
See the various maven plugins dependency:list and antrun:run (regexp and concat)

https://github.com/eclipse/jetty.project/blob/jetty-9.4.x/jetty-gcloud/jetty-gcloud-session-manager/pom.xml

@olamy
Copy link
Member Author

olamy commented Apr 1, 2019 •
edited

doh I don't really like this antrun... I would prefer write a maven plugin :)

@joakime
Copy link
Contributor

joakime commented Apr 1, 2019

Yup, i understand, just pointing out the history of this issue.
A feature in a maven-plugin would be nice.

@janbartel
Copy link
Contributor

It's essential to manage the dependencies - that's the real pain point in the modules. Also have a look at the branch jetty-9.4.x-2140-InfinispanExpiredSessions and you'll see even more modules that need to do the antrun trick in order to manage the large number of transitive deps.

@stale
Copy link

stale bot commented Apr 1, 2020

This issue has been automatically marked as stale because it has been a full year without activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale For auto-closed stale issues and pull requests label Apr 1, 2020
@olamy olamy modified the milestones: 9.4.x, 10.0.x Apr 1, 2020
@stale stale bot removed the Stale For auto-closed stale issues and pull requests label Apr 1, 2020
@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked as stale because it has been a full year without activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale For auto-closed stale issues and pull requests label Jun 2, 2021
@joakime joakime removed the Stale For auto-closed stale issues and pull requests label Jun 2, 2021
@joakime joakime mentioned this issue Jun 2, 2021
Closed
olamy added a commit that referenced this issue Sep 14, 2021
@olamy
Issue #3514 start work on interpolation of mod files
ead6da9 
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
olamy added a commit that referenced this issue Sep 15, 2021
@olamy
Issue #3514 start work on interpolation of mod files
1e45dc5 
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
olamy added a commit that referenced this issue Sep 15, 2021
@olamy
Issue #3514 start work on interpolation of mod files
84b4fc6 
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
@olamy
Copy link
Member Author

olamy commented Sep 16, 2021

to prevent issues with the current usage of ${} in mod files. Interpolation of values from pom will be based on the delimiter @....@ such @log4j2.version@

olamy added a commit that referenced this issue Sep 16, 2021
@olamy
Issue #3514 start work on interpolation of mod files
78b4ef2 
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
olamy added a commit that referenced this issue Sep 16, 2021
@olamy
Issue #3514 interpolation of versions from pom in mod files
0550774 
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
olamy added a commit that referenced this issue Sep 16, 2021
@olamy
Issue #3514 interpolation of versions from pom in mod files
d0cf79d 
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
olamy added a commit that referenced this issue Sep 20, 2021
@olamy
Issue #3514 interpolation of versions from pom in mod files
a342776 
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
@olamy olamy added this to To do in Jetty 10.0.7/11.0.7 FROZEN via automation Sep 21, 2021
@olamy olamy moved this from To do to Review in progress in Jetty 10.0.7/11.0.7 FROZEN Sep 21, 2021
joakime added a commit that referenced this issue Sep 22, 2021
@joakime
Merge pull request #6839 from eclipse/jetty-10.0.x_modfiles_filtering
9c06dc2 
Issue #3514 interpolation of mod files to avoid hardcoding version in mod files
@joakime joakime linked a pull request Sep 22, 2021 that will close this issue
Issue #3514 interpolation of mod files to avoid hardcoding version in mod files #6839
Merged
@joakime
Copy link
Contributor

joakime commented Sep 22, 2021

PR #6839 is merged.

@joakime joakime closed this as completed Sep 22, 2021
Jetty 10.0.7/11.0.7 FROZEN automation moved this from Review in progress to Done Sep 22, 2021
olamy added a commit that referenced this issue Sep 23, 2021
@olamy
Issue #3514 backport of mod files filtering
7391590 
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
olamy added a commit that referenced this issue Sep 24, 2021
@olamy
Issue #3514 backport of mod files filtering (#6897)
b286497 
* Issue #3514 backport of mod files filtering

Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>

* ignore keystore file

Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>

* fix directory name

Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>

* fix directory name

Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>

* fix inclusion of keystore file

Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
jmcc0nn3ll pushed a commit to jetty/jetty-assembly-descriptors that referenced this issue Nov 3, 2023
@olamy
part of jetty/jetty.project#3514 to use directories with interpolated…
5c0bb49 
… files

Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olamy olamy

Labels
Build Test
Projects
No open projects
Jetty 10.0.7/11.0.7 FROZEN
Done
Milestone
10.0.x
Development

Successfully merging a pull request may close this issue.

Issue #3514 interpolation of mod files to avoid hardcoding version in mod files jetty/jetty.project
3 participants
@olamy @joakime @janbartel