Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record rules during profiling of ETL scripts (fixes #51) #52

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

agarciadom
Copy link
Contributor

@agarciadom agarciadom commented Sep 11, 2023

This PR is to fix issue #51. The problem was that the RuleProfiler never gets to screen a TransformationRule, because its executeSuperRulesAndBody method directly executes the body StatementBlock so the TransformationRule never goes through the preExecute and postExecute methods of the execution controller.

I have moved the place from which the body is run: TransformationRule now implements IExecutableModuleElementParameter, and the executeSuperRulesAndBody method sets everything up and then puts the TransformationRule through the execution controller as usual.

I also had to modify the ExecutionProfiler, as it assumed that you would never nest rule executions. Turns out this is wrong: an ETL rule can trigger a lazy ETL rule, for instance (or you could use the satisfies(...) operation in EVL).

This pull request is only a draft for now, since I'd like for someone else to look at this and tell me if the approach is correct before I start adding automated tests for it. @kolovos, could you give it a look?

@agarciadom
Copy link
Contributor Author

Here is a screenshot of the Flowchart2HTML transformation, after this fix:

image

@agarciadom agarciadom marked this pull request as draft September 11, 2023 18:43
@agarciadom agarciadom self-assigned this Sep 11, 2023
@agarciadom agarciadom changed the title Draft: Record rules during profiling of ETL scripts (fixes #51) Record rules during profiling of ETL scripts (fixes #51) Sep 11, 2023
@agarciadom
Copy link
Contributor Author

All tests are passing locally. Waiting for Jenkins results.

@agarciadom
Copy link
Contributor Author

Tests are green on Jenkins as well.

@agarciadom agarciadom marked this pull request as ready for review November 25, 2023 00:45
@agarciadom
Copy link
Contributor Author

Dimitris, what are your thoughts on this PR?

@arcanefoam
Copy link
Contributor

I think this PR is ready @kolovos

Copy link
Contributor

@kolovos kolovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch for ETL looks good to me, although ideally we’d also want to include guard execution time (and possibly super-rule execution time). On a more general note, the Rules tab doesn’t seem to be working with other languages of Epsilon either (I’ve tried EVL and ECL/EML but nothing shows up). It may be the case that instead of patching ETL we’re better off temporarily removing the Rules tab until we have a consistent solution for all Epsilon languages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants