Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove iml and xml files. #866

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

nikhilnanivadekar
Copy link
Contributor

No description provided.

motlin and others added 4 commits April 15, 2020 04:25
Signed-off-by: Craig P. Motlin <cmotlin@gmail.com>
…and update .gitignore.

Signed-off-by: Craig P. Motlin <cmotlin@gmail.com>
Signed-off-by: Nikhil Nanivadekar <nikhil.nanivadekar@bnymellon.com>
Signed-off-by: Nikhil Nanivadekar <nikhil.nanivadekar@bnymellon.com>
@motlin
Copy link
Contributor

motlin commented Apr 17, 2020

Is this still a draft @nikhilnanivadekar?

I'm curious what you did in TeamCity to get this to work.

The only surprise here is misc.xml. That file is partially churn and partially useful. It includes entry point annotations, null annotations, and the list of pom.xml files. We can go ahead and remove it and see what happens. This is for your awareness.

@nikhilnanivadekar
Copy link
Contributor Author

This is still in draft yes. There seems to be a bug in IntelliJ runner wherein the inspection configuration is not honored. A bug is raised for the same: https://youtrack.jetbrains.com/issue/IDEA-237928

@motlin
Copy link
Contributor

motlin commented Apr 17, 2020

@nikhilnanivadekar I'll watch that issue, thanks. Did you experiment with subsets? Removing iml but not the xml files for example?

@nikhilnanivadekar
Copy link
Contributor Author

nikhilnanivadekar commented Apr 17, 2020

Yes I did. I think it works with one of my trials. But I need to go back and check which one worked fine. I need to post that to the issue as well :)

@donraab
Copy link
Contributor

donraab commented Jan 18, 2021

@nikhilnanivadekar Is this still in draft? Should we close it? (power of suggestion got me to click the wrong button by accident)

@donraab donraab closed this Jan 18, 2021
@donraab donraab reopened this Jan 18, 2021
@donraab
Copy link
Contributor

donraab commented Sep 3, 2022

@nikhilnanivadekar should we close this or do you want to try and finish it?

@nikhilnanivadekar
Copy link
Contributor Author

nikhilnanivadekar commented Sep 4, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants