Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1453 issue, From int to LongAdder #1531

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lightgrey7
Copy link

No description provided.

Copy link
Contributor

@donraab donraab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @lightgrey7 ! I think this change looks good. The extra benefit of being thread safe, while not strictly necessary here, I think is not bad if someone wants to use this type with a parallel Stream. The checkstyle build is failing, probably on the placement of the comments. If you can address those issues and rebase, I will approve and merge. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants