Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation added in 2-Collection_Containers.adoc file for Bags #1416

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sandip1805
Copy link
Contributor

Provided example for creating bags using different ways and also provided example of using different set of methods available inside it.

#1387

…mitive types.

Provided example for creating bags using different way and also provided example of using different set of methods available inside it.

eclipse#1387
@donraab
Copy link
Contributor

donraab commented Dec 22, 2022

Hi @sandip1805, this section should be for primitive bags (e.g. IntBag/MutableIntBag/ImmutableIntBag, DoubleBag/MutableDoubleBag/ImmutableDoubleBag, etc.). MutableBag is an object bag and would be documented in a different section.

@sandip1805
Copy link
Contributor Author

sandip1805 commented Dec 23, 2022 via email

@sandip1805
Copy link
Contributor Author

Hi @sandip1805, this section should be for primitive bags (e.g. IntBag/MutableIntBag/ImmutableIntBag, DoubleBag/MutableDoubleBag/ImmutableDoubleBag, etc.). MutableBag is an object bag and would be documented in a different section.

Hi @donraab , I have incorporated suggested changes, could you please have a look and provide suggestion if any?

@sandip1805
Copy link
Contributor Author

Hi @donraab , Build is failing with below reason, can you suggest what is causing issue here?

06:08:20:502 [INFO] Eclipse Collections Parent Project ................. FAILURE [01:59 min] 06:08:20:503 [INFO] Eclipse Collections Code Generator ................. SUCCESS [ 3.425 s] 06:08:20:504 [INFO] Eclipse Collections Code Generator Maven Plugin .... SUCCESS [ 3.339 s] 06:08:20:506 [INFO] Eclipse Collections API ............................ SUCCESS [ 12.958 s] 06:08:20:507 [INFO] Eclipse Collections Main Library ................... SUCCESS [ 48.336 s] 06:08:20:509 [INFO] Eclipse Collections Test Utilities ................. SUCCESS [ 4.720 s] 06:08:20:510 [INFO] Eclipse Collections Fork Join Utilities ............ SUCCESS [ 3.598 s] 06:08:20:511 [INFO] ------------------------------------------------------------------------ 06:08:20:512 [INFO] BUILD FAILURE 06:08:20:513 [INFO] ------------------------------------------------------------------------ 06:08:20:514 [INFO] Total time: 05:14 min 06:08:20:514 [INFO] Finished at: 2023-01-02T06:08:20Z 06:08:20:515 [INFO] ------------------------------------------------------------------------ Error: 0:582 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.2.0:aggregate (default-cli) on project eclipse-collections-parent: An error has occurred in Javadoc report generation: Error: 0:600 [ERROR] Exit code: 1 - Loading source files for package org.eclipse.collections.codegenerator.tools...

@donraab
Copy link
Contributor

donraab commented Jan 17, 2023

@sandip1805 Please squash your commits and rebase your PR. That should address the build failures as they were fixed in a another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants