#705 Add interfaces for MultiReader List/Set/Bag #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donraab
reviewed
May 3, 2019
...ections-api/src/main/java/org/eclipse/collections/api/factory/bag/MultiReaderBagFactory.java
Outdated
Show resolved
Hide resolved
donraab
reviewed
May 3, 2019
...ections-api/src/main/java/org/eclipse/collections/api/factory/bag/MultiReaderBagFactory.java
Outdated
Show resolved
Hide resolved
donraab
reviewed
May 3, 2019
eclipse-collections-api/src/main/java/org/eclipse/collections/api/bag/MultiReaderBag.java
Show resolved
Hide resolved
donraab
reviewed
May 3, 2019
...tions-api/src/main/java/org/eclipse/collections/api/factory/list/MultiReaderListFactory.java
Show resolved
Hide resolved
donraab
reviewed
May 3, 2019
...tions-api/src/main/java/org/eclipse/collections/api/factory/list/MultiReaderListFactory.java
Outdated
Show resolved
Hide resolved
donraab
reviewed
May 3, 2019
...tions-api/src/main/java/org/eclipse/collections/api/factory/list/MultiReaderListFactory.java
Outdated
Show resolved
Hide resolved
donraab
reviewed
May 3, 2019
...ections-api/src/main/java/org/eclipse/collections/api/factory/set/MultiReaderSetFactory.java
Show resolved
Hide resolved
donraab
reviewed
May 3, 2019
...ections-api/src/main/java/org/eclipse/collections/api/factory/set/MultiReaderSetFactory.java
Outdated
Show resolved
Hide resolved
donraab
reviewed
May 3, 2019
...ections-api/src/main/java/org/eclipse/collections/api/factory/set/MultiReaderSetFactory.java
Outdated
Show resolved
Hide resolved
donraab
reviewed
May 3, 2019
eclipse-collections-api/src/main/java/org/eclipse/collections/api/list/MultiReaderList.java
Show resolved
Hide resolved
donraab
reviewed
May 3, 2019
eclipse-collections-api/src/main/java/org/eclipse/collections/api/set/MultiReaderSet.java
Show resolved
Hide resolved
donraab
reviewed
May 3, 2019
donraab
reviewed
May 3, 2019
donraab
requested changes
May 3, 2019
motlin
reviewed
May 3, 2019
| * @since 10.0. | ||
| */ | ||
| public interface MultiReaderBag<T> | ||
| extends MutableBag<T> |
There was a problem hiding this comment.
An interesting question is whether these should extend MutableBagIterable vs MutableBag, MutableSetIterable vs MutableSet. I suppose we could keep it as is and add the other interfaces only if we add other multi-reader implementations.
| { | ||
| void withReadLockAndDelegate(Procedure<MutableBag<T>> procedure); | ||
|
|
||
| void withWriteLockAndDelegate(Procedure<MutableBag<T>> procedure); |
There was a problem hiding this comment.
All usages of Procedure should be generified. IntelliJ may show a warning and an auto-fix here in newish versions of IntelliJ. Specifically:
void withReadLockAndDelegate(Procedure<? super MutableBag<T>> procedure);
void withWriteLockAndDelegate(Procedure<? super MutableBag<T>> procedure);There was a problem hiding this comment.
I'm not sure about this actually. I realized this API is older and you just pulled it up to an interface.
There was a problem hiding this comment.
yes, that is indeed what happened - I have now got my forked repo up to date now and corrected the above
Signed-off-by: canthonyl <cheung.yi.lung@gmail.com>
donraab
approved these changes
May 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi please find this PR for #705