Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create interfaces for MultiReader collections. #705

Closed
donraab opened this issue Mar 29, 2019 · 1 comment
Closed

Create interfaces for MultiReader collections. #705

donraab opened this issue Mar 29, 2019 · 1 comment

Comments

@donraab
Copy link
Contributor

donraab commented Mar 29, 2019

The three MultiReader collections do not currently have interfaces with any specialized APIs. This means you cannot call methods like withReadLockAndDelegate and withWriteLockAndDelegate unless you have the implementation class in your code. This requires you to construct the implementation classes explicitly, and means you cannot use the factory methods for creating the classes.

MutableList<Integer> list = Lists.multiReader.with(1, 2, 3);
// no access to withReadLockAndDelegate or withWriteLockAndDelegate

vs.

MultiReaderFastList<Integer> list = MultiReaderFastList.newListWith(1, 2, 3);
// access to withReadLockAndDelegate or withWriteLockAndDelegate

@donraab donraab assigned donraab and unassigned donraab Mar 29, 2019
canthonyl added a commit to canthonyl/eclipse-collections that referenced this issue May 1, 2019
@canthonyl canthonyl mentioned this issue May 1, 2019
canthonyl added a commit to canthonyl/eclipse-collections that referenced this issue May 2, 2019
canthonyl added a commit to canthonyl/eclipse-collections that referenced this issue May 2, 2019
Signed-off-by: canthonyl <cheung.yi.lung@gmail.com>
canthonyl added a commit to canthonyl/eclipse-collections that referenced this issue May 3, 2019
Signed-off-by: canthonyl <cheung.yi.lung@gmail.com>
donraab added a commit that referenced this issue May 6, 2019
#705 Add interfaces for MultiReader List/Set/Bag
@donraab
Copy link
Contributor Author

donraab commented May 6, 2019

Fixed by @canthonyl in #719

@donraab donraab closed this as completed May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant