Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Testcontainers 1.15.1 and use prebuilt image for DB2 #858

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aguibert
Copy link
Member

  • Upgrade to Testcontainers 1.15.1, mainly because it contains a fix needed to use Testcontainers on Mac OS
  • Use prebuilt image for DB2 so we can avoid using a file system mount (not supported on some OSes)

@aguibert aguibert self-assigned this Dec 16, 2020
@aguibert aguibert requested a review from vietj December 16, 2020 21:55
@aguibert
Copy link
Member Author

@vietj please review if you can

@bsideup
Copy link

bsideup commented Dec 17, 2020

@aguibert FYI you could also use withClasspathResourceMapping, it uses the copy strategy instead of a volume mapping which works reliably on any system :)

Copy link
Member

@vietj vietj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires a work-with CQ, did you file it ?

@aguibert
Copy link
Member Author

@vietj I did not. It's been about a year since I filed my last CQ. Can you please remind me of the process?

@julianladisch
Copy link
Contributor

I also support this pull request because it fixes testcontainers/testcontainers-java#2605 that affects me and the fix ships with testcontainers >= 1.14.2.

@vietj
Copy link
Member

vietj commented Feb 12, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants