Add a close method to AsyncMultiMap #2270
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows cluster managers to free resources they use to maintain the state. Needed for vert-x3/issues#316 Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
|
@vietj PTAL |
|
how did it work before without a close method ? |
|
can we try instead to use java refs ? we have several places in vertx where we do that for better usability |
|
Sorry I can't see what you mean... :( |
|
weak references, look at NetClientImpl |
|
Not sure how we could. We have to unregister listeners on the HZ map and
the ISPN cache. See the related cluster manager PRs
2018-01-10 16:40 GMT+01:00 Julien Viet <notifications@github.com>:
… weak references, look at NetClientImpl
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2270 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABbltt_R65ZUl5ro0jLWWaLO3zVY6YJbks5tJNn6gaJpZM4RZa_H>
.
|
|
I think you can on the map proxy itself as only the client has a ref to it, can't you ? |
|
Sorry I don't understand. In any case, HZ or ISPN may still hold resources
related to the listener. So unregistering it seems mandatory
2018-01-10 16:52 GMT+01:00 Julien Viet <notifications@github.com>:
… I think you can on the map proxy itself as only the client has a ref to
it, can't you ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2270 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABblth_wv49rMIfcs-AX7rou89HzBV5Hks5tJNyxgaJpZM4RZa_H>
.
|
|
@vietj can you take another look before we close the 3.5.1 round? Thanks |
|
vert-x3/issues#316 closed (won't fix) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows cluster managers to free resources they use to maintain the state.
Needed for vert-x3/issues#316