Rework the handling of profiles #995
Conversation
laeubi
force-pushed
the
rework_profile_handling
branch
2 times, most recently
from
f633925
to
a08089d
Compare
tycho-core/src/test/java/org/eclipse/tycho/core/ee/StandardExecutionEnvironmentTest.java
Outdated
Show resolved
Hide resolved
laeubi
force-pushed
the
rework_profile_handling
branch
from
a08089d
to
247665b
Compare
laeubi
force-pushed
the
rework_profile_handling
branch
3 times, most recently
from
7a02746
to
6297443
Compare
laeubi
force-pushed
the
rework_profile_handling
branch
from
6297443
to
91425b5
Compare
|
@akurtakov there is a "Java18ResolutionTest" that currently fails because the highest JDK available to our Jenkins build is java 17 (for github actions) I see the following options:
all other tests succeed, don'T know whats wrong with the jenkins CI ... |
|
I'm quite busy with 4.24/4.25 stream duties. Once done there I'll be back on tycho, hopefully @mickaelistria beats me to it. |
|
Adding Java 18 to the toolchain sounds best option to me. |
laeubi
force-pushed
the
rework_profile_handling
branch
from
91425b5
to
952c84d
Compare
I have added Java 18 now. |
laeubi
force-pushed
the
rework_profile_handling
branch
2 times, most recently
from
531cf4f
to
3cd676d
Compare
|
Currently the setup-java task produces weird results: actions/setup-java#337 ... |
laeubi
force-pushed
the
rework_profile_handling
branch
3 times, most recently
from
79d392c
to
d0cc04e
Compare
|
I disabled the Java 18 test for now unless either
is fixed, @eclipse/technology-tycho-committers would be good to express your support for any or both tickets to be fixed, this will essentially be useful for SWT as well. |
|
I also opened: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1388 |
tycho-core/src/main/java/org/eclipse/tycho/core/ee/ListSystemPackages.java
Outdated
Show resolved
Hide resolved
|
I like the general idea and it's a natural continuation of other changed that have happened on this topic over last versions. I believe there are some parts of this patch that could be isolated a bit as they are not really contributing directly to the goal and are more preliminary fix/cleanups. It would be nice if you can separate separate commits for those; that would greatly facilitate review and also history navigation when we need to look back at this change in the future.. |
laeubi
force-pushed
the
rework_profile_handling
branch
from
d0cc04e
to
60429ae
Compare
laeubi
force-pushed
the
rework_profile_handling
branch
2 times, most recently
from
bcf7de8
to
ea4ecf1
Compare
tycho-core/src/main/java/org/eclipse/tycho/core/ee/StandardExecutionEnvironment.java
Outdated
Show resolved
Hide resolved
- do not embed any static profile - compute the java packages based on the running vm and toolchains - fall back to "higher" profiles if an exact match is not found - do not validate BREEs against static list of names - fix java 9 compatibility of ListSystemPackages
laeubi
force-pushed
the
rework_profile_handling
branch
from
ea4ecf1
to
980ea62
Compare
|
Rebased and remove unnecessary changes... @mickaelistria anything you think should be extracted or are we fine here? |
|
Thanks for this great change, it allows to support newer Java versions without need to change anything in Tycho. Awesome! |
do not embed any static profile
compute the java packages based on the running vm and toolchains
fall back to "higher" profiles if an exact match is not found
do not validate BREEs against static list of names
Fixes Unknown OSGi execution environment: 'JavaSE-19' #958
Fixes Remove warning about No system packages found in profile nor toolchain for missing JRE #655
Fixes Tycho should find Toolchain JRE by version #276
Fixes Tycho publishes too much #155