Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a Tycho Workspace Reader #586

Merged
merged 6 commits into from Jun 12, 2022

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Jan 29, 2022

No description provided.

@github-actions
Copy link

github-actions bot commented Jan 29, 2022

Unit Test Results

263 tests   259 ✔️  46m 3s ⏱️
152 suites      4 💤
152 files        0

Results for commit ef14627.

♻️ This comment has been updated with latest results.

@akurtakov
Copy link
Member

What is the status of this one? It helps finishing PRs so we get less waiting on builds.

@laeubi
Copy link
Member Author

laeubi commented Mar 9, 2022

This needs release of maven 3.8.5 to be finished.

@laeubi
Copy link
Member Author

laeubi commented Mar 9, 2022

@akurtakov maybe we can exclude PRs with a certain label (or simply ones marked as WIP) from the eclipse infra ci build?

@laeubi
Copy link
Member Author

laeubi commented Mar 9, 2022

@akurtakov I have enabled to skip draft PRs from the build for now, I think this is suitable as we have GH action as a first check.

@akurtakov
Copy link
Member

What is the status here? The dash licensetool patch is merged and the longer PRs stay in the queue the less likely it is to be finished and at the end become just noise in the system.

@laeubi
Copy link
Member Author

laeubi commented Apr 7, 2022

This waits for apache/maven#695 and maven 3.8.6 release.

@laeubi
Copy link
Member Author

laeubi commented Apr 18, 2022

The maven release containing the fix is currently planned "something around 2022-05-08"

@laeubi
Copy link
Member Author

laeubi commented Jun 12, 2022

Maven 3.8.6 is out!

@laeubi laeubi force-pushed the issue_585_workspacereader branch from e5ab2a1 to 5811cb1 Compare June 12, 2022 04:11
@laeubi laeubi changed the title Hello World for #585 Provide a Tycho Workspace Reader Jun 12, 2022
@laeubi laeubi marked this pull request as ready for review June 12, 2022 06:01
@laeubi
Copy link
Member Author

laeubi commented Jun 12, 2022

@akurtakov any idea? When running in "full" builds one get:

Error: org.eclipse.tycho.plugins.p2.extras.MirrorMojoTest.testMirrorWithPlatformFilter Time elapsed: 0.195 s <<< ERROR!
java.lang.SecurityException: class "org.apache.commons.io.output.NullOutputStream"'s signer information does not match signer information of other classes in the same package
at org.eclipse.tycho.plugins.p2.extras.MirrorMojoTest.setUp(MirrorMojoTest.java:50)

but running the tycho-extras/tycho-p2-extras-plugin alone succeeds...

@akurtakov
Copy link
Member

My first idea would be that commons.io classes are loaded from 2 different jars - one signed the other not or signed with different certificates.

@laeubi
Copy link
Member Author

laeubi commented Jun 12, 2022

That's really strange, I replaced commons i/o here with plain java, lets see if that helps...

@akurtakov
Copy link
Member

Something I learned from years on Fedora Java stack - using libraries is great as it gives you years of tested code and also this has to be well planned and aligned in the whole stack as otherwise you wish to have written that single function yourself.

@laeubi laeubi merged commit a7101b7 into eclipse-tycho:master Jun 12, 2022
@laeubi laeubi added this to the 3.0 milestone Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants