[tycho-4.0.x] Consider the version string when adding bnd requirements #3828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently Tycho ignores the version string for buildpath entries defined in pde.bnd what leads to faulty dependency requirements. This now correctly evaluates the version string and maps it to a P2 requirement. (cherry picked from commit 7e3ba0e)
Test Results 591 files ±0 591 suites ±0 3h 48m 18s ⏱️ - 13m 47s For more details on these failures, see this check. Results for commit cae88d0. ± Comparison against base commit 878c1e2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintotycho-4.0.x:Questions ?
Please refer to the Backport tool documentation