[tycho-4.0.x] Resolve classpath entries against project base directory #3818 #3822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a linked .classpath file, the path entries within that file are resolved against the directory containing the .classpath file instead of the project base directory into which the .classpath file is linked. With this change, the paths within a .classpath file are resolved against a passed EclipseProject. An existing regression test for linked .classpath files is enhanced to not contain all linked resources in the same folder (thus hiding the bug of using the folder containing the linked .classpath file for resolving classpath entry paths). Fixes #3818 (cherry picked from commit 7490426)
Test Results394 files 394 suites 2h 27m 41s ⏱️ Results for commit a5076d0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintotycho-4.0.x:Questions ?
Please refer to the Backport tool documentation