Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow parallel execution of compilation and package plugin #27

Merged
merged 2 commits into from Apr 9, 2021

Conversation

jhonnen
Copy link
Contributor

@jhonnen jhonnen commented Apr 9, 2021

issue #25

@jhonnen jhonnen changed the title Allow parallel execution of compilation and package plugin (#25) Allow parallel execution of compilation and package plugin Apr 9, 2021
@mickaelistria
Copy link
Contributor

Have you audited the code to verify that this mojo executions are actually thread safe?

@jhonnen
Copy link
Contributor Author

jhonnen commented Apr 9, 2021

Yes, AFAICT there's nothing that requires synchronization. Also I did not see any issues when trying it on our project.

@mickaelistria
Copy link
Contributor

OK, I also went through those mojos and didn't figure out some dangerous path for parallelization. Let's merge.

@mickaelistria mickaelistria merged commit 44469c2 into eclipse-tycho:master Apr 9, 2021
@mickaelistria mickaelistria added this to the 2.4 milestone Apr 9, 2021
@mickaelistria mickaelistria linked an issue Apr 9, 2021 that may be closed by this pull request
@mickaelistria
Copy link
Contributor

This causes #183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relax synchronization in Mojos
3 participants