Add integration test for issue #2426 #2433
Conversation
| <product uid="ppa.product" id="product" application="application" version="1.0.0.qualifier" useFeatures="false" includeLaunchers="false"> | ||
|
|
||
| <launcherArgs> | ||
| <programArgs>-blah1 -blah2 -configuration @user.dir/configuration |
There was a problem hiding this comment.
have you tried writing each arg in one line?
There was a problem hiding this comment.
Yes, still fails. If you want I could add another product with multiline args
| @@ -0,0 +1,49 @@ | |||
| /******************************************************************************* | |||
| * Copyright (c) 2011 Sonatype Inc. and others. | |||
There was a problem hiding this comment.
Whats the correct header? I believe I copied it from one of the files from the test package
There was a problem hiding this comment.
If you created the file as a whole, you should use the current year and your name here, if you extend a existing file at laest update the year (e.g. 2011, 2023) and add you to the contributor list.
|
ECA now succeed! So if you squash / rebase this should succeed and be ready to merged. |
Test Results 582 files +3 582 suites +3 3h 37m 23s ⏱️ - 2m 21s For more details on these failures, see this check. Results for commit 4adf043. ± Comparison against base commit e28d416. ♻️ This comment has been updated with latest results. |
|
I hope i'm doing this right, i've never done that |
This PR only inlude tests. The test checks that the program args
-configurationwhich was added to the .product file will exist in the resulting .ini file