Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Tycho dependency-resolution for clean-only builds by default (#166) #168

Conversation

HannesWell
Copy link
Member

This PR intends to solve issue #166 by skipping Tycho's dependency resolution by default for builds whose only goal is clean.

@mickaelistria do you know if there is any Constant for the "clean" goal String?

…ilds by default

Signed-off-by: Hannes Wellmann <wellmann.hannes1@gmx.net>
@mickaelistria
Copy link
Contributor

I looked in maven source code and found no defintion for "clean".
Note tha the "signed-off-by" footer is not mandatory anymore ( https://bugs.eclipse.org/bugs/show_bug.cgi?id=558653#c30 )

@mickaelistria mickaelistria merged commit c339cbe into eclipse-tycho:master Jul 2, 2021
@mickaelistria mickaelistria added this to the 2.4 milestone Jul 2, 2021
@mickaelistria mickaelistria linked an issue Jul 2, 2021 that may be closed by this pull request
@HannesWell HannesWell deleted the skipDependencyResolutionOnClean branch July 3, 2021 06:27
@HannesWell
Copy link
Member Author

I looked in maven source code and found no defintion for "clean".

To bad.

Note tha the "signed-off-by" footer is not mandatory anymore ( https://bugs.eclipse.org/bugs/show_bug.cgi?id=558653#c30 )

Thank you for that information. The commit messages become very unfamiliar. So empty. No Change-ID and no signed-off. 😄

@HannesWell
Copy link
Member Author

Should I add an entry to the release notes about this change? I think this is a relevant change other would like to be informed about.

@mickaelistria
Copy link
Contributor

sure, feel free to mention it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip Tycho dependency resolution for clean-only builds by default
2 participants