Remove BuildQualifierMojo project.basedir option

Already ignored in all latest versions.
eclipse-tycho · Apr 11, 2022 · a3b66d0 · a3b66d0
1 parent 6ef197a
commit a3b66d0
Show file tree

Hide file tree

Showing 6 changed files with 3 additions and 15 deletions.
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -122,7 +122,9 @@ The following are removed:
 	- MirrorMojo's includePacked
 	- PublishFeaturesAndBundlesMojo reusePack200Files
 
-- ...
+#### BuildQualifierMojo project.basedir option removed
+
+It was totally ignored in all latest versions.
 
 
 ## 2.7.1

diff --git a/tycho-packaging-plugin/src/main/java/org/eclipse/tycho/buildversion/BuildQualifierMojo.java b/tycho-packaging-plugin/src/main/java/org/eclipse/tycho/buildversion/BuildQualifierMojo.java
@@ -16,7 +16,6 @@
 import static org.eclipse.tycho.TychoProperties.QUALIFIED_VERSION;
 import static org.eclipse.tycho.TychoProperties.UNQUALIFIED_VERSION;
 
-import java.io.File;
 import java.text.SimpleDateFormat;
 import java.util.Date;
 import java.util.Map;
@@ -97,14 +96,6 @@ public class BuildQualifierMojo extends AbstractVersionMojo {
     @Parameter(defaultValue = "yyyyMMddHHmm")
     protected SimpleDateFormat format;
 
-    /**
-     * @deprecated This parameter is deprecated and may be removed in future versions of Tycho.
-     */
-    @Deprecated
-    // TODO this should not be configurable
-    @Parameter(property = "project.basedir")
-    protected File baseDir;
-
     @Parameter(property = "forceContextQualifier")
     protected String forceContextQualifier;
 

diff --git a/tycho-packaging-plugin/src/test/resources/projects/buildqualifier/fullyqualified/pom.xml b/tycho-packaging-plugin/src/test/resources/projects/buildqualifier/fullyqualified/pom.xml
@@ -18,7 +18,6 @@
         <configuration>
           <packaging>eclipse-plugin</packaging>
           <format>yyyyMMddHHmm</format>
-          <baseDir>target/projects/buildqualifier/fullyqualified/</baseDir>
         </configuration>
       </plugin>
     </plugins>

diff --git a/tycho-packaging-plugin/src/test/resources/projects/buildqualifier/noqualifier/pom.xml b/tycho-packaging-plugin/src/test/resources/projects/buildqualifier/noqualifier/pom.xml
@@ -18,7 +18,6 @@
         <configuration>
           <packaging>eclipse-plugin</packaging>
           <format>yyyyMMddHHmm</format>
-          <baseDir>target/projects/buildqualifier/noqualifier/</baseDir>
         </configuration>
       </plugin>
     </plugins>

diff --git a/tycho-packaging-plugin/src/test/resources/projects/buildqualifier/p001/pom.xml b/tycho-packaging-plugin/src/test/resources/projects/buildqualifier/p001/pom.xml
@@ -22,7 +22,6 @@
         <version>${tycho-version}</version>
         <configuration>
           <format>yyyyMMddHHmm</format>
-          <baseDir>target/projects/buildqualifier/p001/</baseDir>
         </configuration>
       </plugin>
     </plugins>

diff --git a/tycho-packaging-plugin/src/test/resources/projects/buildqualifier/p002/pom.xml b/tycho-packaging-plugin/src/test/resources/projects/buildqualifier/p002/pom.xml
@@ -22,8 +22,6 @@
         <version>${tycho-version}</version>
         <configuration>
           <format>yyyyMMddHHmm</format>
-
-          <baseDir>target/projects/buildqualifier/p002/</baseDir>
         </configuration>
       </plugin>
     </plugins>