New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update TS versions for TD and TM #845
chore: update TS versions for TD and TM #845
Conversation
We have issues in browser-bundle... grr |
What about this error: https://github.com/eclipse/thingweb.node-wot/actions/runs/3263939568/jobs/5363790618 ? |
'binding-firestore-browser-bundle' vs. 'browser-bundle'
Thanks! I missed to store an opened file ... |
The issue with browserify remains :-( |
The error message is as follows (at least locally)
https://www.npmjs.com/package/@types/bl seems to be used by coap. @JKRhb maybe you know whether those types are used somewhere not properly... I might be wrong but maybe you have a hint.. |
Hmm, I tried to reproduce the error, @danielpeintner, but I haven't seen any issues regarding However, one of the issues linked in browserify/browserify#1986 seems to have a similar problem (see rdfjs/N3.js#310), related to Edit: One comment in the last issue I linked suggests a workaround until the bug is fixed in browserify: rdfjs/N3.js#310 (comment) |
Very strange... the issue locally does not go away. If I call
According to According to my understanding and https://www.npmjs.com/package/@types/bl it should not be installed directly. Am I wrong?
I tried to add the workaround but I cannot check locally whether it works (see issue before) |
Thanks for the hint regarding the |
node_modules/modbus-serial/ModbusRTU.d.ts:2:22 - error TS7016: Could not find a declaration file for module './ports/testport'. 'C:/Projects/WoT/thingweb/thingweb.node-wot-danielpeintner/node_modules/modbus-serial/ports/testport.js' implicitly has an 'any' type. 2 import TestPort from './ports/testport';
node-coap v1.2.2 seems to have resolved the coap issue. Thanks @JKRhb! |
firestore fails. Other than that I think this PR is finally fine now. @relu91 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talked offline, it seems that also the browser examples work! merging.
No description provided.