Perform remote backend copy via http #13039
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
reviewed
Oct 30, 2023
jonah-iden
force-pushed
the
jiden/remote-http-copy
branch
from
f904fcf
to
6f86a14
Compare
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
jonah-iden
force-pushed
the
jiden/remote-http-copy
branch
from
ca31dcd
to
6d27ce0
Compare
|
@jonah-iden Is this ready for a re-review? |
|
I'll look into this in the new year. This isn't a high prio topic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
There is a strong indication that copying the backend to remote systems via http is a faster than using sftp.
On my local system copying the zipped theia backend, http was 2.5x faster then sftp. I sadly wasn't able to test it with an actual remote system.
How to test
i created a small docker container here https://hub.docker.com/repository/docker/jonahiden/remote-test-ubuntu-ssh/general
you can connect to it via ssh with user: test pass: test
also open port 8080 or some other port (other ports need configuration in the theia settings) for the http copy
Follow-ups
Review checklist
Reminder for reviewers